Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fill): blockchain_test to check intermidiate post states in blockchain_test #1033

Open
winsvega opened this issue Dec 19, 2024 · 1 comment
Labels
needs-discussion Needs discussion before proceeding scope:fill Scope: fill command type:feat type: Feature

Comments

@winsvega
Copy link
Collaborator

winsvega commented Dec 19, 2024

shouldn we have

blockchain_test(
        genesis_environment=Environment(),
        pre=pre,
        post=[post1, post2, post3],
        blocks=[Block(txs=[tx_set_pointer_storage, tx_set_sender_storage, tx_reset_code])],
    )

so we validate post state of each block in chain test, not just the final one?

or the post can be part of a block itself and then post in blockchain_test is final post

@danceratopz danceratopz added type:feat type: Feature scope:fill Scope: fill command labels Dec 19, 2024
@danceratopz
Copy link
Member

Yup, great idea. We should absolutely add this.

@danceratopz danceratopz changed the title blockchain_test to check intermidiate post state feat(fill): blockchain_test to check intermidiate post states in blockchain_test Dec 19, 2024
@danceratopz danceratopz added the needs-discussion Needs discussion before proceeding label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion Needs discussion before proceeding scope:fill Scope: fill command type:feat type: Feature
Projects
None yet
Development

No branches or pull requests

2 participants