Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF Implementers Call #48 #1051

Closed
poojaranjan opened this issue May 22, 2024 · 9 comments
Closed

EOF Implementers Call #48 #1051

poojaranjan opened this issue May 22, 2024 · 9 comments

Comments

@poojaranjan
Copy link
Contributor

poojaranjan commented May 22, 2024

Meeting Info

May 29, 2024 , 15:00 UTC

Duration: 60 minutes

Zoom: https://us02web.zoom.us/j/88940506383?pwd=aTdsbHVyMTNDSUFHYmhTWlI2ZEVldz09

📅 Subscribe to the Ethereum Protocol Call calendar for calendar invites

Resources

Agenda

Please add other agenda items or links to discuss.

@pdobacz
Copy link

pdobacz commented May 27, 2024

Some items to add to the agenda. Spec updates:

@marioevz
Copy link
Member

Testing:

We want to create custom pre-releases and versioning for features such as EOF and Verkle, which are actively being worked on, but have not been signaled to be included in a Prague devnet.

  • We want to create a custom tag to be able to automatically package the tests and make a pre-release in a more automated fashion, and it will be like "[email protected]"
  • We also want to create a custom changelog (CHANGELOG_EOF.md) for all things included in this prerelease, once the feature makes it into the devnet schedule, we can point to the custom changelog to show all previous changes and history
  • We want to create a custom fork, for example EOF, and this fork will appear as "prague" the transition tool (or any fork name it's given), but it's important to be able to not fail filling if something like the "requests_hash" is not present in the information returned from the transition tool.

@shemnon
Copy link
Contributor

shemnon commented May 29, 2024

Decision on EOF testing

  • EOF Code is presumed to be in runtime mode
  • If a flag (TBD) is present in the EOF tests, then the code is in initcode mode
    This allows for testing to make intelligent use of the valid EOF containers in blockchain tests.

@shemnon
Copy link
Contributor

shemnon commented May 29, 2024

Call was generally favorable to Mario's testing suggestions without any notable objection.

One request is to have the naming FORK+EIP - such as Cancun+7692
Multiples would be EIP/RIP numbers, in order. Cancun+615+1057+7692

@shemnon
Copy link
Contributor

shemnon commented May 29, 2024

We will revisit ipsilon/eof#118 in next weeks agenda.

@shemnon
Copy link
Contributor

shemnon commented May 29, 2024

Danno's take on #118 - It causes problems with (a) storage and (b) nonce-based addresses.

For storage, the runtime could read/write storage from an EOA, which is an ongoing issue with EIP-7702. We don't want to be mis-alighed with their decisions.

For nonce-based addresses, the returned contract address from the create tx call will not have a contract at it, as the EOFCREATE call would create a different contract ad a salt based address. This for sure broke older dev tooling that assumed the contract address was nonce based from the account and never checked the transaction receipt, some may still do that when polling the address for info from RPC. It also makes repeated deployements difficult as we would have to chagne the salt on each call.

We would either introduce inconsistencies with legacy without need or we would need to re-work some assumptions, such as allowing EOFCREATE to inherit the calling address if it is a create transactions, which feels just as hacky as it sounds.

@diega
Copy link

diega commented May 31, 2024

@poojaranjan Hi, is there a recording for this one?

@poojaranjan
Copy link
Contributor Author

@diega
https://youtu.be/zteyvDI_BHc

@poojaranjan
Copy link
Contributor Author

Closing in favor of #1055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants