Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump evmone to 0.13.0 and define Osaka as a supported EVM version #15622

Open
cameel opened this issue Dec 6, 2024 · 2 comments
Open

Bump evmone to 0.13.0 and define Osaka as a supported EVM version #15622

cameel opened this issue Dec 6, 2024 · 2 comments
Assignees
@r0qs
Labels
EOF high impact Changes are very prominent and affect users or the project in a major way. low effort There is not much implementation work to be done. The task is very easy or tiny. must have Something we consider an essential part of Solidity 1.0.

Comments

@cameel
Copy link
Member

cameel commented Dec 6, 2024 •
edited
Loading

The ability to execute all semantic tests requires an update to evmone 0.13.0.

While at it, we should also add Osaka as a valid EVM version and move all the currently implemented EOF functionality to it to match evmone/evmc.
@cameel cameel added low effort There is not much implementation work to be done. The task is very easy or tiny. high impact Changes are very prominent and affect users or the project in a major way. must have Something we consider an essential part of Solidity 1.0. EOF labels Dec 6, 2024
@nikola-matic nikola-matic self-assigned this Dec 9, 2024
@nikola-matic nikola-matic assigned r0qs and unassigned nikola-matic Dec 9, 2024
@cameel cameel changed the title Bump EVMC to v12 and define Osaka as a supported EVM version Bump evmone to v13 and define Osaka as a supported EVM version Dec 9, 2024
@cameel cameel changed the title Bump evmone to v13 and define Osaka as a supported EVM version Bump evmone to 0.13.0 and define Osaka as a supported EVM version Dec 9, 2024
@cameel
Copy link
Member Author

cameel commented Dec 10, 2024

Small correction: I just realized that we're already on the latest EVMC v12 (#15320). It's evmone that we need to update here.

@floor-licker
Copy link

@roqs are you still doing this or could I take a shot at it? I've read the past PRs involving updating evmone versions and I think I get the idea. Looks like there's just a handful of changes to be made in scripts/install_evmone.ps1 , scripts/install_evmone.ps1, and test/Common.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r0qs r0qs

Labels
EOF high impact Changes are very prominent and affect users or the project in a major way. low effort There is not much implementation work to be done. The task is very easy or tiny. must have Something we consider an essential part of Solidity 1.0.
Projects
Solidity Focus Board
Status: To do
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cameel @r0qs @nikola-matic @floor-licker and others