Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved build script #14502

Closed
wants to merge 2 commits into from
Closed

Conversation

criadoperez
Copy link
Contributor

Makes 2 improvements:

  1. Checks if git is installed before executing the command. If not, it will inform the user to do so.
  2. Git Tag Check: The command git tag --points-at HEAD might produce multiple tags. To handle this scenario, it will use the first one if it happens.

@github-actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@ekpyron
Copy link
Member

ekpyron commented Aug 21, 2024

Thanks for the PR, but we don't see a particular need for these changes and checking for the first git tag is not necessarily correct if there were more tags either, so we're closing the PR.

@ekpyron ekpyron closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants