Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Can we move testeth back into cpp-ethereum? #23

Open
pirapira opened this issue Mar 22, 2018 · 6 comments
Open

Can we move testeth back into cpp-ethereum? #23

pirapira opened this issue Mar 22, 2018 · 6 comments
Labels
question Further information is requested

Comments

@pirapira
Copy link
Member

Discussion so far
#9 (comment)
#9 (comment)
#9 (comment)
#9 (comment)
#9 (comment)
#9 (comment)

@pirapira pirapira mentioned this issue Mar 22, 2018
2 tasks
@pirapira
Copy link
Member Author

pirapira commented Mar 22, 2018

I think ethereum/tests#436 is a blocker. If we move the process back to cpp-ethereum repository now, whenever tests are updated, a new PR (like this) would appear in cpp-ethereum, for testing the test cases.

@pirapira pirapira added the question Further information is requested label May 2, 2018
@winsvega
Copy link
Contributor

winsvega commented May 9, 2018

I guess we will have to move it back or support the testeth in cpp.
Because cpp tests via RPC are too slow and wont run in travis build in time untill we optimize cpp client to do be able to do that

@gumb0
Copy link
Member

gumb0 commented May 9, 2018

We have testeth copy in cpp-ethereum which we use to run the tests now. Given that test format is not supposed to change much we can continue to use it even in retesteth era, right?

@winsvega
Copy link
Contributor

winsvega commented May 9, 2018

I guess yes. but there will be some changes. And it wont be capable of generating new tests.

@gumb0
Copy link
Member

gumb0 commented May 9, 2018

Not generating the tests is fine. Changes to the test format are not fine, but we can decide later what's easier - supporting the changes or making RPC test calls faster

@winsvega
Copy link
Contributor

winsvega commented May 9, 2018

The blockchain test format stays.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants