Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in chainId for BlockchainTests in EIP-6780 Selfdestruct Tests #1394

Open
anvacaru opened this issue Jul 26, 2024 · 1 comment
Open

Comments

@anvacaru
Copy link

I noticed that some of the BlockchainTests tests, mainly the ones under cancun/eip6780_selfdestruct, are executed on a state that has the chainId set to 0 instead of 1. Is there a reason they have a different chainId than the rest of the test suite?

Alternatively, would you consider storing the chainId under the _info field of the JSON test? Or add it as a new field on the same level as sealEngine and network? I know it is already part of the transaction field, but I consider that a post-state check, similar to sender.

@winsvega
Copy link
Collaborator

this are generated by pyspecs. .py fillers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants