Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove indirection via ComponentService when increasing/decreasing balance/fees in InstanceStore #486

Open
doerfli opened this issue Jul 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@doerfli
Copy link
Contributor

doerfli commented Jul 8, 2024

Currently all services that increase/decrease balance/fee amount in the InstanceStore use an indirect call via ComponentService to methods like increaseBundleBalance or decreaseBundleBalance. This indirection increases gas costs and can also be confusing.
We should replace this indirection with direct calls to InstanceStore from the service. Therfore we need to duplicate the increaseBalance, decreaseBalance, increaseFees, decreaseFees for all component type as well as bundle/distributor. (duplication is required to handle authz).

@doerfli doerfli added enhancement New feature or request smartcontract labels Jul 8, 2024
@doerfli doerfli added this to the GIF v3 Audit Ready milestone Jul 8, 2024
@doerfli doerfli self-assigned this Jul 8, 2024
@doerfli doerfli modified the milestones: GIF v3 Audit Ready, GIF v3 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant