Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gif admin role transfer #723

Open
rapidddenis opened this issue Sep 23, 2024 · 0 comments
Open

Gif admin role transfer #723

rapidddenis opened this issue Sep 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@rapidddenis
Copy link
Collaborator

In current implementation some RegistryAdmin functions are restricted to GIF_ADMIN_ROLE. This role is granted upon registry admin initialization, in completeSetup().
Problem:
RegistryAdmin does not provide any function for granting/revoking roles thus GIF_ADMIN_ROLE cannot be transferred

Solution 1:
1). add transferGifAdmin(address from, address to)
2). transfer is atomic combination of revoke(oldAddress) and grant(newAddress)

Solution 2:
1). make RegistryAdmin inherit NftOwnable
2). link it to nft id owned by gif admin (e.g. some service nft id or staking)
3). for function restricted to gif admin role use onlyOwner() modifier instead of restricted()

@rapidddenis rapidddenis added the enhancement New feature or request label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant