Change NetworkConfig #127
Merged
Change NetworkConfig #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying arka with
|
| Latest commit: |
efeca7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4511f171.arka-3qg.pages.dev |
| Branch Preview URL: | https://change-networkconfig.arka-3qg.pages.dev |
vignesha22
requested review from
arddluma,
ch4r10t33r,
kanthgithub,
0xSulpiride and
lbw33
ch4r10t33r
requested changes
Aug 22, 2024
| @@ -1,7 +1,7 @@ | |||
| [ | |||
| { | |||
| "chainId": 1, | |||
| "bundler": "https://ethereum-bundler.etherspot.io/", | |||
| "bundler": "https://rpc.etherspot.io/ethereum", | |||
There was a problem hiding this comment.
Aren't we using https://rpc.etherspot.io/<chainId> format?
| @@ -59,6 +59,16 @@ | |||
| "MultiTokenPaymasterOracleUsed": "chainlink", | |||
| "entryPoint": "0x0000000071727De22E5E9d8BAf0edAc6f37da032" | |||
| }, | |||
| { | |||
| "chainId": 50, | |||
| "bundler": "https://rpc.etherspot.io/v2/50", | |||
There was a problem hiding this comment.
Please be consistent in the URL format. Stick to using chainId or chainName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
etherspot.iosubstringTypes of changes
What types of changes does your code introduce?
Further comments (optional)