Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move web3[tester] splinter to extras_require[test] #140

Open
njgheorghita opened this issue Jan 16, 2019 · 1 comment · May be fixed by #160
Open

Move web3[tester] splinter to extras_require[test] #140

njgheorghita opened this issue Jan 16, 2019 · 1 comment · May be fixed by #160

Comments

@njgheorghita
Copy link
Contributor

See the conversation here

@ghost
Copy link

ghost commented Jun 6, 2019

If someone install web3 version 5 with pip install web3==5.0.0b2, he ends up with ethpm==0.1.4a19.

Requiring web3 with pkg_resources fails:

..stlines/protocol/contract-deploy-tools (git)-[master] % python
Python 3.6.7 (default, Oct 22 2018, 11:32:17) 
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pkg_resources; pkg_resources.require("web3")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bbralf/trustlines/venv/lib/python3.6/site-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/home/bbralf/trustlines/venv/lib/python3.6/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'pytest-ethereum<1.0.0,>=0.1.3a6; extra == "tester"' distribution was not found and is required by web3
>>> 

Removing [tester] from the Requires-Dist: web3[tester] (<6,>=5.0.0b1) line in .../site-packages/ethpm-0.1.4a19.dist-info/METADATA makes the above pkg_resources.require succeed.

I do think this is a serious issue that needs to be fixed. It basically breaks every script using setuptools console_scripts with web3 as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant