Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate anchor links break stuff! #131

Open
smartcontracts opened this issue Jan 12, 2019 · 2 comments
Open

Duplicate anchor links break stuff! #131

smartcontracts opened this issue Jan 12, 2019 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@smartcontracts
Copy link
Member

Describe the bug
We currently have situations where anchor links are duplicated. For example, the Research page has several "#research-questions" and "#resources" anchors:

https://www.learnplasma.org/en/research/#research-questions

This means that if you click on any "#research-questions" anchor on the page:

img1

You'll automatically get sent to the first anchor:

img2

Expected behavior
I think a good way to solve this for now is to have a script that detects duplicate anchor tags and adds -n to the end of the tag. That means we'll have "#research-questions-1" or "#research-questions-2" etc etc.

@smartcontracts smartcontracts added bug Something isn't working good first issue Good for newcomers labels Jan 12, 2019
@iamonuwa
Copy link
Contributor

@kfichter, I'll work on this immediately

@smartcontracts
Copy link
Member Author

@iamonuwa awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants