Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use linter with pyenv #35

Open
sttobia opened this issue Sep 13, 2019 · 0 comments
Open

Use linter with pyenv #35

sttobia opened this issue Sep 13, 2019 · 0 comments

Comments

@sttobia
Copy link

sttobia commented Sep 13, 2019

As infomation for everyone using the linter while using pyenv, some small fixes are needed because string-bytes path mix-ups. Return paths need to be decoded. So to speak:

  • in bin/init_linter_git_hooks the return of the function get_git_repo_root needs to be changed to:
return repo_root.decode()
  • in git_hooks.py, the return of the function get_git_repo_root similarly to:
return run_command_in_folder('git rev-parse --show-toplevel',
                               some_folder_in_root_repo).decode()
  • similarly, in linter.py, change the return of the function run_command_in_folder to:
return command_output.decode()

Maybe this could be permanently fixed in a future release.

@sttobia sttobia changed the title Install linter using a pyenv version. Install linter using pyenv Sep 13, 2019
@sttobia sttobia changed the title Install linter using pyenv Use linter with pyenv Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant