Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support structlog #108

Closed
ddorian opened this issue Feb 13, 2024 · 4 comments · Fixed by #109
Closed

Support structlog #108

ddorian opened this issue Feb 13, 2024 · 4 comments · Fixed by #109
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ddorian
Copy link

ddorian commented Feb 13, 2024

Does it support structlog?
@etianen etianen added enhancement New feature or request good first issue Good for newcomers labels Feb 13, 2024
@etianen
Copy link
Owner

etianen commented Feb 13, 2024

Not yet, but it's on my list of things to add for v1.1.

3rd-party logging integrations have to be added as a new Capturer integration (see loguru as an example):

https://github.com/etianen/logot/blob/main/logot/_loguru.py

I'd happily accept a PR for this feature, and any other 3rd party integrations. Otherwise, hold tight, and it will arrive in a week or so.

@etianen
Copy link
Owner

etianen commented Feb 13, 2024

@will-ockmore - You mentioned you were keen to add this too.

@etianen
Copy link
Owner

etianen commented Feb 13, 2024

structlog support would get pretty powerful once #25 lands too

@etianen
Copy link
Owner

etianen commented Feb 13, 2024

See hynek/structlog#596 for discussion

@will-ockmore will-ockmore mentioned this issue Feb 14, 2024
Merged
@etianen etianen changed the title Structlog support Support structlog Feb 15, 2024
etianen pushed a commit that referenced this issue Feb 17, 2024
@will-ockmore
Added structlog support (#109)
e7349c6 
- Adds `StructlogCapturer` and related docs. 

Follows `loguru` extension structure, borrowing inspiration from the
structlog testing tools. I've matched the suggested version range in
hynek/structlog#596.

Closes #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added structlog support will-ockmore/logot
2 participants
@etianen @ddorian