phase_N <-> kaN "redundancy"

[kostrzewa]

There is a certain redundancy from boundary.[c,h] in D_psi.c now that c99 complex is being integrated, but I don't know how much of a performance impact, if any, it would make to simply replace instances of phase_N by -kaN (where N = {0,1,2,3} ) Any ideas?

[deuzeman]

I doubt there is any noticeable performance impact of removing one of the two variables and it certainly makes things more readable, so this has my vote.

[urbach]

The main reason for having both is a sign. In Hopping_Matrix there is a relative sign missing, and to match the definitions in between D_psi and Hopping_Matrix, I introduced the negative phase factors. This one could of probably also fix in the code of D_psi now easily with the new complex implementation, couldn't one? (are the macros a problem there?)

Otherwise, I don't expect performance issues there.