Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data flow during fit_transform #24

Open
Mr-Geekman opened this issue Aug 14, 2023 · 0 comments
Open

Fix data flow during fit_transform #24

Mr-Geekman opened this issue Aug 14, 2023 · 0 comments
Labels
enhancement New feature or request optimization Performance or memory optimization

Comments

@Mr-Geekman
Copy link

Issue by alex-hse-repository
Thursday Jan 19, 2023 at 15:01 GMT
Originally opened as tinkoff-ai#1075


🚀 Feature Request

The current version of data flow during fit_transform is not optimal, it might be improved.

Proposal

  1. In to_pandas method:
  • Add flag copy:bool=True, implement the corresponding logic
  • Remove segments from slices
  1. In BaseTransform class:
  • Method fit should request the reference to the full df
  • Methods transform/inverse_transform should request the copy of the df with required features

Test cases

  1. Test that flag copy works, get the dataframe, change it and compare with dataframe in dataset
  2. Fix tests for BaseTransform if nessesary

Additional context

No response

@Mr-Geekman Mr-Geekman added enhancement New feature or request optimization Performance or memory optimization labels Aug 14, 2023
@Mr-Geekman Mr-Geekman moved this to Specification in etna board Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Performance or memory optimization
Projects
Status: Specification
Development

No branches or pull requests

1 participant