Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] KINESIS_INITIALIZE_STREAMS evaluation mishandles quotes #319

Open
mpatnode opened this issue Jul 5, 2022 · 5 comments
Open

[BUG] KINESIS_INITIALIZE_STREAMS evaluation mishandles quotes #319

mpatnode opened this issue Jul 5, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@mpatnode
Copy link

mpatnode commented Jul 5, 2022

Describe the bug
Quotes used in KINESIS_INITIALIZE_STREAMS will cause a parsing error. This is new behavior which perhaps was triggered by one of the underlying component upgrades.

To Reproduce
Steps to reproduce the behavior:

  1. Set your variable using a quoted string like: KINESIS_INITIALIZE_STREAMS="audit-stream:1:us-east-1"
  2. Start localstack
  3. See error:
    INFO:localstack.services.kinesis.kinesis_mock_server: kinesis.mock.InvalidArgumentException: Stream Name '"audit_stream' contains invalid characters

Expected behavior
The surrounding quote characters in environment variables should be ignored.

Additional context
This worked with a 3 month old localstack image, and only broke recently, potentially in conjunction with the requirement for the region to be included in the stream name (that was not required in the previous image either)

@mpatnode mpatnode added the bug Something isn't working label Jul 5, 2022
@etspaceman
Copy link
Owner

Could you simply remove the quotes from the value here?

@mpatnode
Copy link
Author

mpatnode commented Jul 5, 2022

Of course. It's just unexpected behavior for environment variables. Perhaps an oddity of docker-compose, since the shell would typically remove those quotes when parsing the set command.

@etspaceman
Copy link
Owner

I'm not entirely sure to be honest. Might also be something that changed in Localstack rather than here. I haven't pushed a release of kinesis-mock since April of this year.

@etspaceman
Copy link
Owner

Resolved

@etspaceman
Copy link
Owner

Wrong issue

@etspaceman etspaceman reopened this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants