New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Encodium.ValidationError for things that aren't Encodium validation errors #6

Open

ktofu opened this issue Jun 30, 2014 · 1 comment

Member

ktofu commented Jun 30, 2014

Doing so breaks encapsulation and is confusing. Worse, could lead to bugs like this:

try:
    do some non-encodium thing.
except ValidationError:
    this should only happen when my validation error is raised

and now you might accidentally miss the encodium error (or vice versa)

Member

XertroV commented Jun 30, 2014

Yeah, this was because I had a ValidationError too but used from encodium import *

Leave this open so we can fix it properly longer term

-----BEGIN EMAIL SIG-----
Max Kaye
https://xk.io
github.com/XertroV
-----END EMAIL SIG-----

On Tue, Jul 1, 2014 at 5:38 AM, Kitten Tofu [email protected]
wrote:

Doing so breaks encapsulation and is confusing. Worse, could lead to bugs
like this:

try:
do some non-encodium thing.except ValidationError:
this should only happen when my validation error is raised

and now you might accidentally miss the encodium error (or vice versa)

—
Reply to this email directly or view it on GitHub
#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment