spring-data-jpa-HHH-13740

Problem with duplicates when fetching multiple many-to-many relations with Hibernate FetchMode.JOIN

• Java version - OpenJDK 11.0.6
• Spring Boot version - 2.2.6.RELEASE
• Spring Data JPA version - 2.2.6.RELEASE
• Hibernate version - 5.4.12.Final

When there are multiple many-to-many relations with FetchMode.JOIN, JpaRepository#getOne(id) returns a result with a child relation of type List containing duplicates.

To avoid MultipleBagFetchException: cannot simultaneously fetch multiple bags when multiple @ManyToMany collections have @Fetch(FetchMode.JOIN), only one collection has type List and others have type Set.

@Entity
@Data
@EqualsAndHashCode(onlyExplicitlyIncluded = true)
public class Book implements Serializable {

  @Id
  @GeneratedValue
  private Long id;

  @NaturalId
  @EqualsAndHashCode.Include
  private String isbn;

  private String title;

  private LocalDate publicationDate;

  @ManyToMany
  @Fetch(FetchMode.JOIN)
  private List<Author> authors = new ArrayList<>();

  @ManyToMany
  @Fetch(FetchMode.JOIN)
  private Set<Category> categories = new LinkedHashSet<>();
}

With the following test data

softwareDevelopment = new Category("Software development");
categoryRepository.save(softwareDevelopment);

systemDesign = new Category("System design");
categoryRepository.save(systemDesign);

martinFowler = new Author("Martin Fowler");
authorRepository.save(martinFowler);

gregorHohpe = new Author("Gregor Hohpe");
authorRepository.save(gregorHohpe);

bobbyWoolf = new Author("Bobby Woolf");
authorRepository.save(bobbyWoolf);

poeaa = new Book();
poeaa.setIsbn("007-6092019909");
poeaa.setTitle("Patterns of Enterprise Application Architecture");
poeaa.setPublicationDate(LocalDate.parse("2002-11-15"));
poeaa.getAuthors().addAll(List.of(martinFowler));
poeaa.getCategories().addAll(List.of(softwareDevelopment, systemDesign));
bookRepository.save(poeaa);

eip = new Book();
eip.setIsbn("978-0321200686");
eip.setTitle("Enterprise Integration Patterns");
eip.setPublicationDate(LocalDate.parse("2003-10-20"));
eip.getAuthors().addAll(List.of(gregorHohpe, bobbyWoolf));
eip.getCategories().addAll(List.of(softwareDevelopment, systemDesign));
bookRepository.save(eip);

a Book entity found by ID contains duplicates in List<Author> authors because Set<Category> categories has size 2: ["Software development", "System design"].

@Transactional(readOnly = true)
@Test
void testFindByIdOneAuthor() {
    Book poeaa = bookRepository.getOne(this.poeaa.getId());
    assertThat(poeaa.getTitle()).isEqualTo(this.poeaa.getTitle());
// The following line results in exception
// because the actual poeaa.authors contains duplicates: ["Martin Fowler", "Martin Fowler"]
    assertThatHasAuthors(poeaa, martinFowler.getFullName());
}

@Transactional(readOnly = true)
@Test
void testFindByIdTwoAuthors() {
    Book eip = bookRepository.getOne(this.eip.getId());
    assertThat(eip.getTitle()).isEqualTo(this.eip.getTitle());
// The following line results in exception
// because the actual eip.authors contains duplicates: ["Gregor Hohpe", "Gregor Hohpe", "Bobby Woolf", "Bobby Woolf"]
    assertThatHasAuthors(eip, gregorHohpe.getFullName(), bobbyWoolf.getFullName());
}

See the test com.example.spring.data.jpa.BookFetchModeJoinWithSetTests.

There are no duplicates in List<Author> authors when Set<Category> categories has size 1.