Switching to toml_edit broke my tests because of sirens in the distance (macrotest)

[ijackson]

Firstly, apologies for filing this ticket here. None of this is the fault of macrotest. IDK what you might want to do about it. But, it took me considerable digging to discover the problem, so I though I should report it here because it was cargo update -p macrotest that triggered the problem. Someone else this happens to might find this ticket, even if it's closed by then.

I have a crate where I use macrotest for testing. macrotest uses toml_edit. toml_edit has an ill-advised API which induced a bug in proc_macro_crate, such that proc_macro_crate doesn't work when Cargo.toml declares the dependencies with syntax like this:

dependencies = { .... }

Humans rarely write like this, but since d551fbf "Use toml_edit instead of basic-toml (#119)", macrotest does. (My git bisect fingered that commit.)

The fact that this happened because macrotest changed to toml_edit, triggering a bug in proc_macro_crate's use of toml_edit again, seems to be coincidence.

OTOH if you feel like this decreases your confidence in toml_edit you might choose to switch horses (toml libraries) again.

Thanks for your attention.

[taiki-e]

It seems proc-macro-crate bug has been fixed.