Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests are failing on alpine / musl based distributions #18

Closed
hrefhref opened this issue May 18, 2020 · 3 comments
Closed

tests are failing on alpine / musl based distributions #18

hrefhref opened this issue May 18, 2020 · 3 comments

Comments

@hrefhref
Copy link
Contributor

As the title says. Happens on this branch or the one in #13. In this repo develop it fails silently, in #13 it fails with Unknown: 0: using regular magic file [binary gargabe]. I wonder if this related to #16. Stay tuned for more details..
@hrefhref hrefhref mentioned this issue May 18, 2020
Open
@hrefhref
Copy link
Contributor Author

Tried by removing the setup_options calls and just initializing magic with NULL as database (for the default) -- and it works now fine on Alpine. So definitely related with #16

@evadne
Copy link
Owner

evadne commented Mar 10, 2021 •
edited
Loading

The version tested did not cope well with warnings printed when using uncompiled magic… Which was fixed in 1.0.1 onwards.

evadne added a commit that referenced this issue Mar 15, 2021
@evadne
Merge branch 'feature/gh-18-alpine-build' into develop
e2331a6
@evadne
Copy link
Owner

evadne commented Mar 15, 2021 •
edited
Loading

Hi, I have added a specific Dockerfile that addresses this scenario FYI

(The underlying issue might have been fixed earlier)

e2331a6

@evadne evadne closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evadne @hrefhref