Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 roadmap #38

Open
3 of 5 tasks
nprail opened this issue Dec 16, 2019 · 4 comments
Open
3 of 5 tasks

2.0 roadmap #38

nprail opened this issue Dec 16, 2019 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@nprail
Copy link
Member

nprail commented Dec 16, 2019

The second major version of npm-audit-html will have a few major new features.

Join the conversation on Slack!

https://slack.event1.io

@nprail nprail added the enhancement New feature or request label Dec 16, 2019
@nprail nprail added this to the 2.0 milestone Dec 16, 2019
@nprail nprail pinned this issue Dec 16, 2019
@cguy
Copy link

cguy commented May 12, 2020

Hello,

If I could suggest two more features:

  • an API endpoint (not just cli) to use the module inside a node project
  • support the auditReportVersion:2 JSON format (in case anyone like me generate the NPM audit JSON report with @npmcli/arborist and npm-audit-report

Anyway your library is nice, wish you the best

Best regards,

@nprail
Copy link
Member Author

nprail commented May 12, 2020

@cguy Thanks for the ideas!

Technically, you actually could use npm-audit-html's API directly. It is just undocumented. And lib/reporter.js should probably be set as the main file in the package.json.

Adding support for auditReportVersion:2 is definitely a must as well.

@cguy
Copy link

cguy commented May 12, 2020

@nprail Thank you for your answer.

Actually, I already checked the reporter file. My concern is it always writes a file on the file system, however through API I could be excepting to get the HTML String :)

Regarding version 2 of the report version, it's quite simple, there is only one layer added after vulnerabilities (the new name of "adventories").

I forked your project for immediate need (added my own ugly code), but it works.

@nprail
Copy link
Member Author

nprail commented May 13, 2020

@cguy Ah, I see. I think it makes sense to move the actual file writing to the CLI and keep the reporter more abstracted from the system.

Yeah, I took a look at the version 2 spec and it doesn't look too bad at all. I'm planning on making a way for there to be various "adapters" for different audit specs like Yarn (#36), v1 and v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants