Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/user-profile-create] 유저 인증 여부 API 구현 완료 #38

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

Qbeom0925
Copy link
Member

작업 내용

유저 인증 여부 API 입니다. 해당 유저가 학교 메일 인증이 완료된 유저인지 확인하는 API입니다.
기존의 Index로 조회하던 방식에서 deviceId로 변경하였습니다. 그 이유는 Index로 조회하는 것에 대해서 테스트 환경에서 Cardinality가 Index 다음으로 높은 DeviceId를 기반으로 조회를 하여 효율적인 테스트 환경 구축을 위해 조회 방식을 바꾸었습니다.

관련 이슈

#37

@Qbeom0925 Qbeom0925 added Feature 기능 개발 Test 테스트 관련 labels Sep 18, 2023
@Qbeom0925 Qbeom0925 self-assigned this Sep 18, 2023
kyubeomHan added 2 commits September 19, 2023 08:37
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

Copy link
Member

@dldmsql dldmsql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내용 모두 확인했습니다! 수고하셨어요 😊

@Auth(require = true)
@GetMapping("/auth")
@Operation(summary = "유저 인증 여부")
@SecurityRequirement(name = "bearerAuth")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 어노테이션은 처음봐요 😮

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이중 어느것 일가요?
@Auth는 커스텀 어노테이션!
@operation는 API 설명!
@securityrequirement 이 API는 Swagger에서 토큰 전달하는 설정입니다! -> Swagger에서 자물쇠가 생깁니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@securityrequirement 이거였어요 : )

@Qbeom0925 Qbeom0925 merged commit 6e0072c into develop Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 기능 개발 Test 테스트 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants