Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.2 not recognizing notes #295

Open
fuhrmanator opened this issue Sep 24, 2019 · 8 comments
Open

4.0.2 not recognizing notes #295

fuhrmanator opened this issue Sep 24, 2019 · 8 comments
Assignees
Milestone

Comments

@fuhrmanator
Copy link
Contributor

fuhrmanator commented Sep 24, 2019

The Note: separator which used to work (3.4.x?) does not work in 4.0.2:

<!-- .slide: data-separator-notes="^Note:" -->

# Title

- blah

Note: Here's a note

In 3.4.x (?) I think I was using the vscode setting:

"revealjs.notesSeparator": "^Note:"

In any case, it was working. Now it's not.

A work-around now is to wrap the note in <aside class="notes"> (is not shown, and shows in speaker notes):

<aside class="notes">Note: Here's a note</aside>
@evilz
Copy link
Owner

evilz commented Sep 25, 2019

😅 I 'd forgetten to parse it

@evilz evilz closed this as completed Sep 25, 2019
@evilz evilz reopened this Sep 25, 2019
@evilz evilz self-assigned this Sep 25, 2019
@evilz evilz added the bug label Sep 25, 2019
@evilz evilz added this to the 4.0 milestone Sep 25, 2019
@evilz evilz mentioned this issue Oct 4, 2019
@orgi
Copy link

orgi commented Oct 23, 2019

Hmm looks like the new version (4.0.3) is already installed on my machine but it still doesn't work. Am I probably missing something?

@orgi
Copy link

orgi commented Oct 23, 2019

Looks like I got it wrong. Instead of writing

note: Some note

I tried to use it like:

note:
* First note line
* Second note line
* ...

Somehow multi-line notes don't seem to be supported without using HTML. Any plans to support that?

@fuhrmanator
Copy link
Contributor Author

In my settings, it's

"revealjs.notesSeparator": "^Note:"

I think it would be case-sensitive (meaning you have to have Note: and not note:.

Either way, it's still not working in my 4.0.3 install on Windows 10.

@fuhrmanator
Copy link
Contributor Author

I tried playing more with it and got this to work:

notesSeparator: "Note:"

But as @orgi pointed out, it won't work for multi-line notes. Bullets (from markdown) in notes are very useful.

@fuhrmanator
Copy link
Contributor Author

@evilz any chance to get this working with multi-line markdown, as discussed at #295 (comment)

@klezm
Copy link

klezm commented Jan 16, 2022

Multiline notes are working within the aside tag. You need to set the data-markdown attribute and for some reason you cannot have blank lines within the aside tag.

<aside class="notes" data-markdown="">
my comment
<!-- NO BLANK LINES -->
- item1
- item2
  - item 2.a
  - item 2.b
- item 3
<br>
more comments
</aside>

@evilz
Copy link
Owner

evilz commented Jan 16, 2022

You are right.
Need to remake all parser for the note.

Actually you can add <br/> to go to new line.

If someone want to code the note parser I took it :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants