✨ Implement block tags and correct skipBalance #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 79c5734 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jan 27, 2024
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Jan 27, 2024
|
Warning Rate Limit Exceeded@roninjin10 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 59 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates bring a consistent renaming from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
roninjin10
force-pushed
the
actions-tyypes-consistency
branch
from
1fee319 to
e5210f8
Compare
roninjin10
force-pushed
the
block_tag_type_fix
branch
from
5ab3505 to
51f4fee
Compare
roninjin10
force-pushed
the
actions-tyypes-consistency
branch
from
e5210f8 to
c333bf7
Compare
roninjin10
force-pushed
the
block_tag_type_fix
branch
from
51f4fee to
9ca3483
Compare
roninjin10
force-pushed
the
actions-tyypes-consistency
branch
from
c333bf7 to
c2d7451
Compare
roninjin10
force-pushed
the
block_tag_type_fix
branch
from
9ca3483 to
27f169b
Compare
1 task
roninjin10
force-pushed
the
actions-tyypes-consistency
branch
from
c2d7451 to
f2d2820
Compare
roninjin10
force-pushed
the
block_tag_type_fix
branch
from
27f169b to
cf70983
Compare
roninjin10
force-pushed
the
actions-tyypes-consistency
branch
from
f2d2820 to
9455c63
Compare
roninjin10
force-pushed
the
block_tag_type_fix
branch
from
cf70983 to
c333346
Compare
roninjin10
force-pushed
the
actions-tyypes-consistency
branch
from
9455c63 to
ec93a3f
Compare
roninjin10
force-pushed
the
block_tag_type_fix
branch
2 times, most recently
from
b935986 to
e56c8a7
Compare
roninjin10
force-pushed
the
block_tag_type_fix
branch
2 times, most recently
from
f044923 to
587b03c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 10
Configuration used: CodeRabbit UI
Files selected for processing (34)
- docs/src/content/docs/reference/@tevm/actions-types/type-aliases/BaseCallParams.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/callHandler.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/contractHandler.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/ethCallHandler.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/scriptHandler.md (1 hunks)
- docs/src/content/docs/reference/@tevm/procedures/functions/callProcedure.md (1 hunks)
- docs/src/content/docs/reference/@tevm/procedures/functions/contractProcedure.md (1 hunks)
- docs/src/content/docs/reference/@tevm/procedures/functions/scriptProcedure.md (1 hunks)
- packages/actions-types/docs/type-aliases/BaseCallParams.md (1 hunks)
- packages/actions-types/src/params/BaseCallParams.ts (1 hunks)
- packages/actions/docs/functions/callHandler.md (1 hunks)
- packages/actions/docs/functions/contractHandler.md (1 hunks)
- packages/actions/docs/functions/ethCallHandler.md (1 hunks)
- packages/actions/docs/functions/scriptHandler.md (1 hunks)
- packages/actions/src/eth/ethCallHandler.js (1 hunks)
- packages/actions/src/eth/ethCallHandler.spec.ts (4 hunks)
- packages/actions/src/tevm/callHandler.js (2 hunks)
- packages/actions/src/tevm/callHandler.spec.ts (7 hunks)
- packages/actions/src/tevm/callHandlerOpts.js (2 hunks)
- packages/actions/src/tevm/contractHandler.js (5 hunks)
- packages/actions/src/tevm/contractHandler.spec.ts (14 hunks)
- packages/actions/src/tevm/scriptHandler.js (3 hunks)
- packages/actions/src/tevm/scriptHandler.spec.ts (7 hunks)
- packages/memory-client/src/createMemoryClient.js (1 hunks)
- packages/procedures/docs/functions/callProcedure.md (1 hunks)
- packages/procedures/docs/functions/contractProcedure.md (1 hunks)
- packages/procedures/docs/functions/scriptProcedure.md (1 hunks)
- packages/procedures/src/eth/ethCallProcedure.js (1 hunks)
- packages/procedures/src/requestProcedure.spec.ts (5 hunks)
- packages/procedures/src/tevm/callProcedure.js (1 hunks)
- packages/procedures/src/tevm/scriptProcedure.js (1 hunks)
- packages/zod/src/params/zBaseCallParams.js (1 hunks)
- packages/zod/src/params/zBaseCallParams.spec.ts (1 hunks)
- tevm/docs/actions-types/type-aliases/BaseCallParams.md (1 hunks)
Additional comments: 79
packages/actions/src/eth/ethCallHandler.js (3)
- 4-4: Parameter type changed from
EVMtoVMto align with the updated import.- 10-12: Introduced
createTransactionandskipBalanceparameters in the call handler options.- 12-12: Error handling logic correctly throws the first error if any are present in the response.
packages/zod/src/params/zBaseCallParams.spec.ts (1)
- 12-13: Added tests for new properties
skipBalanceandcreateTransactioninzBaseCallParams.packages/actions/docs/functions/ethCallHandler.md (2)
- 9-9: Updated parameter name in function signature from
evmtovm.- 13-13: Parameter description updated to reflect the change to
VM.docs/src/content/docs/reference/@tevm/actions/functions/ethCallHandler.md (2)
- 8-8: Updated parameter name in function signature from
evmtovm.- 12-12: Parameter description updated to reflect the change to
VM.packages/actions/docs/functions/callHandler.md (2)
- 9-9: Updated parameter name in function signature from
evmtovm.- 15-15: Parameter description updated to reflect the change to
VM.docs/src/content/docs/reference/@tevm/actions/functions/callHandler.md (2)
- 8-8: Updated parameter name in function signature from
evmtovm.- 14-14: Parameter description updated to reflect the change to
VM.packages/actions/docs/functions/scriptHandler.md (2)
- 9-9: Updated parameter name in function signature from
evmtovm.- 15-15: Parameter description updated to reflect the change to
VM.docs/src/content/docs/reference/@tevm/actions/functions/scriptHandler.md (2)
- 8-8: Updated parameter name in function signature from
evmtovm.- 14-14: Parameter description updated to reflect the change to
VM.packages/actions/docs/functions/contractHandler.md (2)
- 9-9: Updated parameter name in function signature from
evmtovm.- 15-15: Parameter description updated to reflect the change to
VM.packages/procedures/docs/functions/callProcedure.md (2)
- 9-9: Updated parameter name in function signature from
evmtovm.- 15-15: Parameter description updated to reflect the change to
VM.docs/src/content/docs/reference/@tevm/actions/functions/contractHandler.md (2)
- 8-8: Updated parameter name in function signature from
evmtovm.- 14-14: Parameter description updated to reflect the change to
VM.packages/procedures/docs/functions/scriptProcedure.md (2)
- 9-9: Updated parameter name in function signature from
evmtovm.- 15-15: Parameter description updated to reflect the change to
VM.docs/src/content/docs/reference/@tevm/procedures/functions/callProcedure.md (2)
- 8-12: Updated parameter name in function signature from
evmtovmand corrected the link to the type alias.- 18-18: Parameter description updated to reflect the change to
VM.packages/procedures/docs/functions/contractProcedure.md (2)
- 9-9: Updated parameter name in function signature from
evmtovm.- 17-17: Parameter description updated to reflect the change to
VM.docs/src/content/docs/reference/@tevm/procedures/functions/scriptProcedure.md (2)
- 8-12: Updated parameter name in function signature from
evmtovmand corrected the link to the type alias.- 18-18: Parameter description updated to reflect the change to
VM.docs/src/content/docs/reference/@tevm/procedures/functions/contractProcedure.md (2)
- 8-12: Updated parameter name in function signature from
evmtovmand corrected the link to the type alias.- 20-20: Parameter description updated to reflect the change to
VM.packages/procedures/src/eth/ethCallProcedure.js (2)
- 5-5: Parameter type changed from
EVMtoVMto align with the updated import.- 11-11: Correctly passes the
vmparameter to thecallProcedurefunction.packages/actions/src/tevm/callHandler.js (3)
- 7-7: Parameter type changed from
EVMtoVMto align with the updated import.- 16-16: Correctly creates a shallow copy of the VM when
createTransactionis false.- 17-33: Error handling logic correctly captures and returns unexpected errors.
packages/actions/src/tevm/callHandlerOpts.js (2)
- 5-5: Introduced typedef
EthRunCallParamsfor clarity in handling EVM call options.- 46-48: Correctly sets
skipBalanceto true if no caller is provided, handling a specific case for call execution.packages/zod/src/params/zBaseCallParams.js (2)
- 7-12: Added new field
createTransactionwith a boolean type and an optional flag, including a description.- 17-17: Updated description for
skipBalanceto clarify its purpose.packages/actions-types/src/params/BaseCallParams.ts (1)
- 7-13: Added new properties
createTransactionandblockTagto theBaseCallParamstype, providing more control over transaction handling and specifying the block number or tag for call execution.packages/actions-types/docs/type-aliases/BaseCallParams.md (1)
- 34-39: Added new optional parameter
createTransactionto the function signature, including a description.tevm/docs/actions-types/type-aliases/BaseCallParams.md (1)
- 34-39: Added new optional parameter
createTransactionto the function signature, including a description.packages/procedures/src/tevm/scriptProcedure.js (1)
- 6-7: Parameter
evmhas been correctly renamed tovmto reflect the usage of Ethereumjs VM.packages/memory-client/src/createMemoryClient.js (2)
- 205-210: The parameters passed to
processRequest,scriptHandler,callHandler, andcontractHandlerhave been correctly updated to usevminstead ofevm.- 216-216: The
ethCallHandlercorrectly receivesvmas its parameter, aligning with the changes made throughout the file.packages/actions/src/eth/ethCallHandler.spec.ts (5)
- 5-5: The import of
VMfrom@ethereumjs/vmis correctly added to support the creation ofvminstances in the tests.- 298-298: The creation of
vmusingVM.create({ evm })is correct, aligning with the updated usage ofvmin the test cases.- 310-310: The replacement of
evmwithvmin theethCallHandlercall is correctly implemented, ensuring consistency with the updated parameter naming.- 326-326: The creation of
vmfor the second test case is consistent with the changes made throughout the file, correctly usingVM.create({ evm }).- 330-330: The replacement of
evmwithvmin the secondethCallHandlercall is correctly implemented, aligning with the updated parameter naming.packages/actions/src/tevm/callHandler.spec.ts (5)
- 5-5: Import of
VMfrom@ethereumjs/vmis correctly added to support the new testing scenarios.- 310-310: Usage of
callHandlerwithvmobject is correct, aligning with the new approach to useVMinstead ofEVM.- 336-337: Introduction of
createTransactionandskipBalanceparameters incallHandlercall is aligned with PR objectives to provide more control over transaction handling.- 367-367: Correct usage of
callHandlerto simulate a contract call that should fail, demonstrating the enhanced testing capabilities.- 401-401: Modification to
evm.runCallfor testing the handling of unexpected errors is a good test case addition.packages/actions/src/tevm/scriptHandler.spec.ts (7)
- 3-3: Import of
VMfrom@ethereumjs/vmis correctly added to support the new testing scenarios.- 296-296: Instantiation of
VMusingawait VM.create()is correct and aligns with the expected usage pattern for theVMobject.- 317-317: Correct usage of
await VM.create()in parameter validation test case.- 344-344: Correct instantiation of
VMfor testing passing in data.- 368-368: Correct instantiation of
VMfor testing invalid function data.- 393-393: Correct usage of
scriptHandlerwith thevmobject to test event decoding failure handling.- 404-404: Correct instantiation of
VMfor testing a call that reverts.packages/actions/src/tevm/contractHandler.spec.ts (12)
- 296-296: Line 296 introduces a new VM instance creation with an
evmobject passed as a parameter. This change aligns with the PR's objective to transition fromEVMtoVM. However, ensure that theVM.createmethod is correctly implemented to accept anEVMinstance as its parameter, as this is not a standard pattern in@ethereumjs/vm.- 308-308: Line 308 uses the newly created
vminstance for contract handling. This change is consistent with the PR's objective. However, verify that thecontractHandlerfunction has been updated to accept and correctly utilize theVMinstance instead of theEVMinstance.- 329-329: Line 329 repeats the VM instance creation pattern seen earlier. As before, ensure that the
VM.createmethod's usage is correct and that thecontractHandlerfunction is compatible with theVMinstance.- 342-342: Line 342 uses the
vminstance in a contract call that is expected to fail. This test case is important for verifying error handling with the newVMinstance. Ensure that thecontractHandlerfunction properly handles and returns errors when using theVMinstance.- 369-369: Line 369 shows another instance of VM creation. Consistency in VM instance creation across tests is good, but again, verify the correctness of this pattern and the compatibility of the
contractHandlerfunction with theVMinstance.- 372-372: Line 372 demonstrates handling a contract not existing using the
vminstance. This test case is crucial for ensuring that the system correctly handles scenarios where contracts are not found. Verify that thecontractHandlerfunction's logic correctly identifies and handles non-existent contracts with theVMinstance.- 396-396: Line 396, like previous instances, creates a VM instance. This pattern is consistent throughout the file. Ensure the
VM.createmethod's usage is correct and that thecontractHandlerfunction is fully compatible with theVMinstance.- 411-411: Line 411 tests the handling of unexpected errors during contract calls with the
vminstance. This is critical for ensuring robust error handling. Verify that thecontractHandlerfunction correctly catches and handles unexpected errors when using theVMinstance.- 434-434: Line 434 shows the VM instance creation for testing invalid contract params. This consistency in VM usage across tests is good. Ensure the
VM.createmethod's usage is correct and that thecontractHandlerfunction properly handles invalid parameters with theVMinstance.- 445-445: Line 445 tests the handling of invalid contract parameters using the
vminstance. This is important for ensuring that the system correctly identifies and reports errors related to invalid parameters. Verify that thecontractHandlerfunction's logic correctly handles invalid parameters with theVMinstance.- 473-473: Line 473 introduces a VM instance for testing the decoding of function data. This test case is important for ensuring that the system can handle scenarios where function data cannot be decoded. Verify that the
contractHandlerfunction correctly handles decoding issues with theVMinstance.- 504-504: Line 504 shows the VM instance creation for testing encodable function data. Consistency in VM usage across tests is good. Ensure the
VM.createmethod's usage is correct and that thecontractHandlerfunction properly handles scenarios where function data is not encodable with theVMinstance.packages/procedures/src/requestProcedure.spec.ts (3)
- 409-409: The instantiation of
VMwithawait VM.create({ evm })inside the test case fortevm_callis correct, ensuring that a fresh VM instance is used for each test. This approach is consistent with best practices for isolation in testing.- 453-453: The instantiation of
VMwithawait VM.create({ evm })inside the error handling test case fortevm_callis correct, ensuring that a fresh VM instance is used for each test. This approach is consistent with best practices for isolation in testing.- 551-553: The instantiation of
VMwithawait VM.create({ evm })inside the test case for handling unexpected errors intevm_scriptis correct, ensuring that a fresh VM instance is used for each test. This approach is consistent with best practices for isolation in testing.
| @@ -480,7 +480,7 @@ describe('requestProcedure', () => { | |||
| describe('tevm_script', async () => { | |||
| it('should work', async () => { | |||
| expect( | |||
| await scriptProcedure(new EVM({}))({ | |||
| await scriptProcedure(await VM.create())({ | |||
There was a problem hiding this comment.
The instantiation of VM with await VM.create() inside the test case for tevm_script is correct, ensuring that a fresh VM instance is used for each test. However, the {} parameter passed to VM.create() is unnecessary and can be omitted for clarity.
- await VM.create({})
+ await VM.create()Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| await scriptProcedure(await VM.create())({ | |
| await scriptProcedure(await VM.create())({ |
| const caller = `0x${'69'.repeat(20)}` as const | ||
| expect( | ||
| await scriptProcedure(evm)({ | ||
| await scriptProcedure(await VM.create({}))({ |
There was a problem hiding this comment.
The instantiation of VM with await VM.create({}) inside the error handling test case for tevm_script is correct, ensuring that a fresh VM instance is used for each test. However, the {} parameter passed to VM.create() is unnecessary and can be omitted for clarity.
- await VM.create({})
+ await VM.create()Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| await scriptProcedure(await VM.create({}))({ | |
| await scriptProcedure(await VM.create())({ |
| @@ -294,6 +295,7 @@ const ERC20_ABI = [ | |||
| describe('callHandler', () => { | |||
| it('should execute a contract call', async () => { | |||
| const evm = new EVM({}) | |||
| const vm = await VM.create({ evm }) | |||
There was a problem hiding this comment.
Instantiation of VM using VM.create({ evm }) is incorrect. The VM.create method does not accept an evm object as a parameter.
- const vm = await VM.create({ evm })
+ const vm = await VM.create()Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| const vm = await VM.create({ evm }) | |
| const vm = await VM.create() |
| @@ -327,10 +329,12 @@ | |||
|
|
|||
| it('should be able to send value', async () => { | |||
| const evm = new EVM({}) | |||
| const vm = await VM.create({ evm }) | |||
There was a problem hiding this comment.
The same issue as previously mentioned regarding VM.create({ evm }) is present here.
Refer to the earlier comment for the fix.
| @@ -347,6 +351,7 @@ | |||
|
|
|||
| it('should handle errors returned during contract call', async () => { | |||
| const evm = new EVM({}) | |||
| const vm = await VM.create({ evm }) | |||
There was a problem hiding this comment.
Again, incorrect instantiation of VM with VM.create({ evm }).
Refer to the earlier comment for the fix.
| @@ -388,11 +393,12 @@ | |||
|
|
|||
| it('should handle the EVM unexpectedly throwing', async () => { | |||
| const evm = new EVM({}) | |||
| const vm = await VM.create({ evm }) | |||
There was a problem hiding this comment.
Incorrect VM.create({ evm }) instantiation is repeated.
Refer to the earlier comment for the fix.
| @@ -387,8 +388,9 @@ describe('scriptHandler', () => { | |||
| }, | |||
| } | |||
| } | |||
| const vm = await VM.create({ evm }) | |||
There was a problem hiding this comment.
Incorrect instantiation of VM with { evm } parameter, similar to the issue identified in callHandler.spec.ts.
- const vm = await VM.create({ evm })
+ const vm = await VM.create()Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| const vm = await VM.create({ evm }) | |
| const vm = await VM.create() |
| /** | ||
| * @type {import('@tevm/actions-types').ScriptResult} | ||
| */ | ||
| let res | ||
| try { | ||
| res = await scriptHandler(evm)({ | ||
| res = await scriptHandler(vm)({ |
There was a problem hiding this comment.
The spread operator is used twice for request.params.deployedBytecode and request.params.gas, leading to redundant code.
- ...(request.params.deployedBytecode ? { deployedBytecode: request.params.deployedBytecode } : {}),
- ...(request.params.gas ? { gas: hexToBigInt(request.params.gas) } : {}),Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| res = await scriptHandler(vm)({ | |
| res = await scriptHandler(vm)({ |
The handling of abi, functionName, and args with type any and setting them to undefined is not ideal. Consider refining the approach to ensure type safety and clarity.
Duplicate handling of gasPrice and gas parameters. Remove the duplicate entries to clean up the code.
- ...(request.params.gasPrice ? { gasPrice: hexToBigInt(request.params.gasPrice) } : {}),
- ...(request.params.gas ? { gas: hexToBigInt(request.params.gas) } : {}),Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| res = await scriptHandler(vm)({ | |
| res = await scriptHandler(vm)({ |
added 9 commits
February 11, 2024 17:00
roninjin10
force-pushed
the
block_tag_type_fix
branch
from
587b03c to
66acaf7
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (34)
- docs/src/content/docs/reference/@tevm/actions-types/type-aliases/BaseCallParams.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/callHandler.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/contractHandler.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/ethCallHandler.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/scriptHandler.md (1 hunks)
- docs/src/content/docs/reference/@tevm/procedures/functions/callProcedure.md (1 hunks)
- docs/src/content/docs/reference/@tevm/procedures/functions/contractProcedure.md (1 hunks)
- docs/src/content/docs/reference/@tevm/procedures/functions/scriptProcedure.md (1 hunks)
- packages/actions-types/docs/type-aliases/BaseCallParams.md (1 hunks)
- packages/actions-types/src/params/BaseCallParams.ts (1 hunks)
- packages/actions/docs/functions/callHandler.md (1 hunks)
- packages/actions/docs/functions/contractHandler.md (1 hunks)
- packages/actions/docs/functions/ethCallHandler.md (1 hunks)
- packages/actions/docs/functions/scriptHandler.md (1 hunks)
- packages/actions/src/eth/ethCallHandler.js (1 hunks)
- packages/actions/src/eth/ethCallHandler.spec.ts (4 hunks)
- packages/actions/src/tevm/callHandler.js (2 hunks)
- packages/actions/src/tevm/callHandler.spec.ts (7 hunks)
- packages/actions/src/tevm/callHandlerOpts.js (2 hunks)
- packages/actions/src/tevm/contractHandler.js (5 hunks)
- packages/actions/src/tevm/contractHandler.spec.ts (14 hunks)
- packages/actions/src/tevm/scriptHandler.js (3 hunks)
- packages/actions/src/tevm/scriptHandler.spec.ts (7 hunks)
- packages/memory-client/src/createMemoryClient.js (2 hunks)
- packages/procedures/docs/functions/callProcedure.md (1 hunks)
- packages/procedures/docs/functions/contractProcedure.md (1 hunks)
- packages/procedures/docs/functions/scriptProcedure.md (1 hunks)
- packages/procedures/src/eth/ethCallProcedure.js (1 hunks)
- packages/procedures/src/requestProcedure.spec.ts (5 hunks)
- packages/procedures/src/tevm/callProcedure.js (1 hunks)
- packages/procedures/src/tevm/scriptProcedure.js (1 hunks)
- packages/zod/src/params/zBaseCallParams.js (1 hunks)
- packages/zod/src/params/zBaseCallParams.spec.ts (1 hunks)
- tevm/docs/actions-types/type-aliases/BaseCallParams.md (1 hunks)
Files skipped from review as they are similar to previous changes (34)
- docs/src/content/docs/reference/@tevm/actions-types/type-aliases/BaseCallParams.md
- docs/src/content/docs/reference/@tevm/actions/functions/callHandler.md
- docs/src/content/docs/reference/@tevm/actions/functions/contractHandler.md
- docs/src/content/docs/reference/@tevm/actions/functions/ethCallHandler.md
- docs/src/content/docs/reference/@tevm/actions/functions/scriptHandler.md
- docs/src/content/docs/reference/@tevm/procedures/functions/callProcedure.md
- docs/src/content/docs/reference/@tevm/procedures/functions/contractProcedure.md
- docs/src/content/docs/reference/@tevm/procedures/functions/scriptProcedure.md
- packages/actions-types/docs/type-aliases/BaseCallParams.md
- packages/actions-types/src/params/BaseCallParams.ts
- packages/actions/docs/functions/callHandler.md
- packages/actions/docs/functions/contractHandler.md
- packages/actions/docs/functions/ethCallHandler.md
- packages/actions/docs/functions/scriptHandler.md
- packages/actions/src/eth/ethCallHandler.js
- packages/actions/src/eth/ethCallHandler.spec.ts
- packages/actions/src/tevm/callHandler.js
- packages/actions/src/tevm/callHandler.spec.ts
- packages/actions/src/tevm/callHandlerOpts.js
- packages/actions/src/tevm/contractHandler.js
- packages/actions/src/tevm/contractHandler.spec.ts
- packages/actions/src/tevm/scriptHandler.js
- packages/actions/src/tevm/scriptHandler.spec.ts
- packages/memory-client/src/createMemoryClient.js
- packages/procedures/docs/functions/callProcedure.md
- packages/procedures/docs/functions/contractProcedure.md
- packages/procedures/docs/functions/scriptProcedure.md
- packages/procedures/src/eth/ethCallProcedure.js
- packages/procedures/src/requestProcedure.spec.ts
- packages/procedures/src/tevm/callProcedure.js
- packages/procedures/src/tevm/scriptProcedure.js
- packages/zod/src/params/zBaseCallParams.js
- packages/zod/src/params/zBaseCallParams.spec.ts
- tevm/docs/actions-types/type-aliases/BaseCallParams.md
Merged
This was referenced Feb 12, 2024
roninjin10
pushed a commit
that referenced
this pull request
Feb 12, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ### Patch Changes - Updated dependencies \[[`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695)]: - @tevm/[email protected] ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ### Patch Changes - Updated dependencies \[[`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695)]: - @tevm/[email protected] ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ### Patch Changes - Updated dependencies \[[`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695)]: - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ### Patch Changes - Updated dependencies \[[`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695)]: - @tevm/[email protected] ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set - [#891](#891) [`7453edc4231d597179cc9bb117bc5df488b99c51`](7453edc) Thanks [@roninjin10](https://github.com/roninjin10)! - Moved state dump and state load to generateCannonicalGenesis and dumpCanonicalGenesis methods on state classes ### Patch Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Fixed bug with state normal mode not shallow copying correctly ## @tevm/[email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ## [email protected] ### Minor Changes - [#890](#890) [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695) Thanks [@roninjin10](https://github.com/roninjin10)! - Updated tevm call actions to not modify the state by default unless createTransaction: true is set ### Patch Changes - Updated dependencies \[[`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695), [`7453edc4231d597179cc9bb117bc5df488b99c51`](7453edc), [`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`64db695b4bf00b1e06909b960e9a498e520f1d73`](64db695)]: - @tevm/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from Block to blockTag
Testing
Explain the quality checks that have been done on the code changes
Additional Information
Your ENS/address:
Summary by CodeRabbit
createTransactionandblockTagto enhance call execution and state update control.evmtovmacross various functions and procedures.evmtovmin multiple handler and procedure functions to align with updated terminology and usage.VMobject usage and the introduction ofcreateTransactionandblockTagparameters.