New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native file upload support #150

Open

n4mespace opened this issue Jun 3, 2024 · 1 comment

Labels

Collaborator

n4mespace commented Jun 3, 2024

Add native file uploads support

strawberry example - https://strawberry.rocks/docs/guides/file-upload
strawberry scalar for file upload - https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/file_uploads/scalars.py

The text was updated successfully, but these errors were encountered:

n4mespace added the enhancement label

Collaborator

kindermax commented Jun 5, 2024

As far as I can tell, indeed many graphql libraries support unofficial graphql spec for file uploads https://github.com/jaydenseric/graphql-multipart-request-spec. But there are some nuances about graphql file uploads:

Apollo Router does not support file uploads (yet) https://www.apollographql.com/docs/ios/file-uploads/-
Apollo Server docs suggest not using graphql file upload https://www.apollographql.com/docs/apollo-server/v3/data/file-uploads/. Instead they recoment upload files with separate API and then pass file ids into graphql api.

In general, I'm not against implementing it, we can do it some other time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment