Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a simpler test case than add11 #34

Closed
s1na opened this issue Dec 10, 2019 · 0 comments · Fixed by #43
Closed

Generate a simpler test case than add11 #34

s1na opened this issue Dec 10, 2019 · 0 comments · Fixed by #43
Labels
evm Eth1 EE supporting EVM

Comments

@s1na
Copy link
Collaborator

s1na commented Dec 10, 2019

The EVM EE fails to produce the correct post state root for the default test case (add11), and therefore I had to disable the evm test in CI (#32). Passing add11 is a longer term task (highlighted requirements in #33). Before that we should nevertheless craft a few test cases manually and work our way up to add11. Initially we should avoid gas handling & SSTORE in the test cases to make things easier.

Similar to state tests the test cases should have a two pre accounts with balances and one with a bytecode. The bytecode should end with the RETURN statement, e.g. it should ADD two numbers and then RETURN the result. We also send along the expected return value as input to EE and the EE after executing bytecode checks the return value against expected value. It should also correctly perform the value transfer from sender to the contract.

@s1na s1na added the evm Eth1 EE supporting EVM label Dec 10, 2019
@s1na s1na closed this as completed in #43 Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evm Eth1 EE supporting EVM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant