From dcbd52e7f1543f97901d3ee92fae5875aeb86f06 Mon Sep 17 00:00:00 2001 From: "ala'n (Alexey Stsefanovich)" Date: Thu, 12 Dec 2024 13:31:45 +0100 Subject: [PATCH 1/2] docs: migration guide update according actual state --- site/views/blogs/ESL v5.0.0 Migartion Guide.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/site/views/blogs/ESL v5.0.0 Migartion Guide.md b/site/views/blogs/ESL v5.0.0 Migartion Guide.md index 90bf57a47..a11f1be21 100644 --- a/site/views/blogs/ESL v5.0.0 Migartion Guide.md +++ b/site/views/blogs/ESL v5.0.0 Migartion Guide.md @@ -57,10 +57,15 @@ The points not marked with `🔧` in the breaking changes section are covered by Note that `activator` property change now is the part of main toggleable flow. - `this.open` of Toggleables doesn't update until super.onShow/super.onHide is called. Make sure you update `this.open` synchronously or manually notify consumers in case the super call of `onShow/onHide` should be postponed. + - #### A11y improvments and focus management (affects ESlPopup) + - `a11y` option introduced and now used to controll the focus management and a11y for `esl-popup`, `esl-tooltip` (footnotes), `esl-share`, `esl-select` (dropdown). + Option available on `ESLToggleable` level and controls focus flow and close on outside action feature. - #### ESL Triggers API Changes - `ESLTrigger` does not have target defined to `::next` by default. You should always define the target explicitly. - #### ESL Panel and Panel Group - `fallback-duration` is no longer in the JSX shape of `ESLPanel` and `ESLPanelGroup`. + - #### ESL Popup + - Attribute `disable-arrow` no longer supported. Use class `disable-arrow` instead. - ### ESL Footnotes - `ESLNote` now based on `ESLBaseTrigger` so active marker now called `active` instead of `tooltip-shown`. From 467e61c57a175333a8fc3881e7a68fe79b9e2063 Mon Sep 17 00:00:00 2001 From: "ala'n (Alexey Stsefanovich)" Date: Thu, 12 Dec 2024 14:25:54 +0100 Subject: [PATCH 2/2] docs: fix review comments Co-authored-by: Anastasiya Lesun <72765981+NastaLeo@users.noreply.github.com> --- site/views/blogs/ESL v5.0.0 Migartion Guide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/site/views/blogs/ESL v5.0.0 Migartion Guide.md b/site/views/blogs/ESL v5.0.0 Migartion Guide.md index a11f1be21..cf7fce1ad 100644 --- a/site/views/blogs/ESL v5.0.0 Migartion Guide.md +++ b/site/views/blogs/ESL v5.0.0 Migartion Guide.md @@ -57,8 +57,8 @@ The points not marked with `🔧` in the breaking changes section are covered by Note that `activator` property change now is the part of main toggleable flow. - `this.open` of Toggleables doesn't update until super.onShow/super.onHide is called. Make sure you update `this.open` synchronously or manually notify consumers in case the super call of `onShow/onHide` should be postponed. - - #### A11y improvments and focus management (affects ESlPopup) - - `a11y` option introduced and now used to controll the focus management and a11y for `esl-popup`, `esl-tooltip` (footnotes), `esl-share`, `esl-select` (dropdown). + - #### A11y improvements and focus management (affects ESlPopup) + - `a11y` option introduced and now used to control the focus management and a11y for `esl-popup`, `esl-tooltip` (footnotes), `esl-share`, `esl-select` (dropdown). Option available on `ESLToggleable` level and controls focus flow and close on outside action feature. - #### ESL Triggers API Changes - `ESLTrigger` does not have target defined to `::next` by default. You should always define the target explicitly.