Skip to content

Commit 883320e

Browse files
authored
Refactoring/305 update dependencies (#306)
* Update dependencies: bucketfs & PTB * Fix poetry objects to pass poetry check * Update .gitignore to include .html-documentation * Update changelog to reflect what happened * Set GitHub token permissions & switch GPU tests to updated PTB * Format with project:fix * Fix warning in github which indicates version is not being set for test-exaslct-alias-script job * Prepare release 3.4.0 * Add changelog.md & version.py to .gitattributes
1 parent 7770e07 commit 883320e

File tree

15 files changed

+66
-49
lines changed

15 files changed

+66
-49
lines changed

.gitattributes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
poetry.lock linguist-generated=true
22
setup.py linguist-generated=true
3+
doc/changes/changelog.md linguist-generated=true
4+
exasol/slc/version.py linguist-generated=true

.github/workflows/checks.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,8 @@ jobs:
193193

194194
test-exaslct-alias-script:
195195
needs: build-matrix
196+
permissions:
197+
contents: read
196198
strategy:
197199
fail-fast: false
198200
matrix: ${{ fromJson(needs.build-matrix.outputs.matrix) }}
@@ -205,7 +207,7 @@ jobs:
205207
- name: Setup Python & Poetry Environment
206208
uses: exasol/python-toolbox/.github/actions/[email protected]
207209
with:
208-
python-version: '${{ matrix.python_version }}'
210+
python-version: ${{ matrix.python-version }}
209211

210212
- name: Test exaslct
211213
run: poetry run exaslct --help

.github/workflows/gpu-tests.yml

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ jobs:
77

88
prep-testbed-gpu:
99
runs-on: ubuntu-24.04
10+
permissions:
11+
contents: read
1012

1113
steps:
1214
- uses: actions/checkout@v4
@@ -23,6 +25,8 @@ jobs:
2325

2426
test-gpu:
2527
needs: prep-testbed-gpu
28+
permissions:
29+
contents: read
2630
strategy:
2731
fail-fast: false
2832
matrix:
@@ -35,23 +39,11 @@ jobs:
3539
steps:
3640
- uses: actions/checkout@v4
3741

38-
#Cannot use exasol/python-toolbox/.github/actions/python-environment here
39-
#because pipx is not installed on int-linux-x64-4core-gpu-t4-ubuntu24.04-1
40-
- name: Setup Python ('${{ matrix.python_version }}')
41-
uses: actions/setup-python@v5
42+
- name: Setup Python & Poetry Environment
43+
uses: exasol/python-toolbox/.github/actions/[email protected]
4244
with:
4345
python-version: '${{ matrix.python_version }}'
44-
45-
- name: Install pipx and poetry
46-
run: |
47-
pip install pipx
48-
pipx install poetry=="2.1.2"
49-
echo "$HOME/.local/bin" >> $GITHUB_PATH
50-
51-
- name: Setup Poetry
52-
run: |
53-
poetry env use python3
54-
poetry install
46+
use-cache: 'false'
5547

5648
- name: Allow unprivileged user namespaces
5749
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

.github/workflows/integration-tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ jobs:
1111

1212
prep-testbed:
1313
runs-on: ubuntu-24.04
14+
permissions:
15+
contents: read
1416

1517
steps:
1618
- uses: actions/checkout@v4
@@ -27,6 +29,8 @@ jobs:
2729

2830
test-all:
2931
needs: prep-testbed
32+
permissions:
33+
contents: read
3034
strategy:
3135
fail-fast: false
3236
matrix:

.github/workflows/slow-checks.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
slow-tests-approval:
1313
name: Approve Slow Tests
1414
runs-on: ubuntu-24.04
15+
permissions:
16+
contents: read
1517

1618
# Even though the environment "manual-approval" will be created automatically,
1719
# it still needs to be configured to require interactive review.
@@ -33,9 +35,13 @@ jobs:
3335
name: Integrations
3436
uses: ./.github/workflows/integration-tests.yml
3537
secrets: inherit
38+
permissions:
39+
contents: read
3640

3741
gpu-tests:
3842
needs: slow-tests-approval
3943
name: Integrations
4044
uses: ./.github/workflows/gpu-tests.yml
4145
secrets: inherit
46+
permissions:
47+
contents: read

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,8 @@ dmypy.json
136136
# Jetbrains
137137
.idea/
138138

139+
# documentation
140+
.html-documentation
139141

140142
# Project
141143
.build_output/

doc/changes/changelog.md

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/changes/changes_3.4.0.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# 3.4.0 - 2025-07-04
2+
3+
## Features
4+
5+
- #292: Created a new nox task to clean up images on dockerhub
6+
7+
## Refactorings
8+
9+
- #301: Update PTB and workflows and activate generation of GH pages
10+
- #305: Updated exasol-bucketfs to 2.0.0
11+
12+
## Security
13+
14+
- #303: Update dependencies on top of 3.3.0, including exasol-toolbox to 1.6.0

doc/changes/unreleased.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1 @@
11
# Unreleased
2-
3-
## Features
4-
5-
- #292: Created a new nox task to clean up images on dockerhub
6-
7-
## Refactorings
8-
9-
- #301: Update PTB and workflows and activate generation of GH pages
10-
11-
## Security
12-
13-
- #303: Update dependencies on top of 3.3.0

exasol/slc/internal/tasks/export/export_container_task.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def get_release_task(self) -> BaseTask:
3535
) # pylint: disable=no-member
3636
return self.create_child_task(
3737
task_class=class_,
38-
**self.required_task_info.params # pylint: disable=no-member
38+
**self.required_task_info.params, # pylint: disable=no-member
3939
)
4040

4141
def get_release_goal(self) -> str:

0 commit comments

Comments
 (0)