Skip to content

Commit c00d2ea

Browse files
edward.mengejsmith
authored andcommitted
Recording exception details in logs to identify issues easier.
1 parent 90f5d81 commit c00d2ea

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

src/Exceptionless/ExceptionlessClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public bool UpdateUserEmailAndDescription(string referenceId, string email, stri
112112
try {
113113
var response = _submissionClient.Value.PostUserDescription(referenceId, new UserDescription(email, description), Configuration, Configuration.Resolver.GetJsonSerializer());
114114
if (!response.Success)
115-
_log.Value.FormattedError(typeof(ExceptionlessClient), "Failed to submit user email and description for event '{0}': {1} {2}", referenceId, response.StatusCode, response.Message);
115+
_log.Value.FormattedError(typeof(ExceptionlessClient), response.Exception, "Failed to submit user email and description for event '{0}': {1} {2}", referenceId, response.StatusCode, response.Message);
116116

117117
return response.Success;
118118
} catch (Exception ex) {

src/Exceptionless/Queue/DefaultEventQueue.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,9 @@ public Task Process() {
109109
_log.Error(typeof(DefaultEventQueue), "Event submission discarded for being too large. The event will not be submitted.");
110110
}
111111
} else if (!response.Success) {
112-
_log.Error(typeof(DefaultEventQueue), String.Concat("An error occurred while submitting events: ", response.Message));
112+
_log.Error(typeof(DefaultEventQueue), response.Exception,
113+
String.IsNullOrEmpty(response.Message) ? "An error occurred while submitting events." :
114+
String.Concat("An error occurred while submitting events: ", response.Message));
113115
SuspendProcessing();
114116
deleteBatch = false;
115117
}

src/Exceptionless/Submission/DefaultSubmissionClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public SubmissionResponse PostEvents(IEnumerable<Event> events, ExceptionlessCon
4343
_client.Value.AddAuthorizationHeader(config.ApiKey);
4444
response = _client.Value.PostAsync(url, content).ConfigureAwait(false).GetAwaiter().GetResult();
4545
} catch (Exception ex) {
46-
return new SubmissionResponse(500, message: ex.Message);
46+
return new SubmissionResponse(500, exception: ex);
4747
}
4848

4949
int settingsVersion;
@@ -71,7 +71,7 @@ public SubmissionResponse PostUserDescription(string referenceId, UserDescriptio
7171
_client.Value.AddAuthorizationHeader(config.ApiKey);
7272
response = _client.Value.PostAsync(url, content).ConfigureAwait(false).GetAwaiter().GetResult();
7373
} catch (Exception ex) {
74-
return new SubmissionResponse(500, message: ex.Message);
74+
return new SubmissionResponse(500, exception: ex);
7575
}
7676

7777
int settingsVersion;

src/Exceptionless/Submission/SubmissionResponse.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace Exceptionless.Submission {
55
public class SubmissionResponse {
6-
public SubmissionResponse(int statusCode, string message = null) {
6+
public SubmissionResponse(int statusCode, string message = null, Exception exception = null) {
77
StatusCode = statusCode;
88
Message = message;
99

@@ -14,6 +14,7 @@ public SubmissionResponse(int statusCode, string message = null) {
1414
UnableToAuthenticate = (HttpStatusCode)statusCode == HttpStatusCode.Unauthorized || (HttpStatusCode)statusCode == HttpStatusCode.Forbidden;
1515
NotFound = (HttpStatusCode)statusCode == HttpStatusCode.NotFound;
1616
RequestEntityTooLarge = (HttpStatusCode)statusCode == HttpStatusCode.RequestEntityTooLarge;
17+
Exception = exception;
1718
}
1819

1920
public bool Success { get; private set; }
@@ -26,5 +27,7 @@ public SubmissionResponse(int statusCode, string message = null) {
2627

2728
public int StatusCode { get; private set; }
2829
public string Message { get; private set; }
30+
31+
public Exception Exception { get; private set; }
2932
}
3033
}

0 commit comments

Comments
 (0)