Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support book URL and checking if user exists for GitLab #30

Open
joelostblom opened this issue Jun 9, 2021 · 1 comment
Open

Support book URL and checking if user exists for GitLab #30

joelostblom opened this issue Jun 9, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@joelostblom
Copy link
Contributor

joelostblom commented Jun 9, 2021

Minor suggestions, currently the book URL and user check is hardcoded to GitHub. Maybe there could be a choice in the beginning about which version control host to use (like with the end for the CI now). Then the rest of the options could be generic ("username", "ci", etc) and the host URL would be prefaced where needed.

Changing the url to gitlab also gives this warning so maybe binder should be turn off if gitlab is chosen (with a messge): WARNING: Currently Binder/JupyterHub repositories must be on GitHub, got https://gitlab.com/

@joelostblom joelostblom added the enhancement New feature or request label Jun 9, 2021
@welcome
Copy link

welcome bot commented Jun 9, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant