-
Notifications
You must be signed in to change notification settings - Fork 2
Keep a way to opening a notebook with the default renderer without uninstalling the extension #30
Comments
Could you clarify your needs here? If it is just that you have an immutable environment (e.g. from a Docker image), you shouldn't need to uninstall the extension to disable it: one can run |
The PR / discussion that introduced this is here: I wonder if it was a bit premature to fully take over the renderer. The terminal approach might be a bit much for students at the moment, I think there is a disable extension UI in Jupyter4.0?! Can't wait :) |
Yup, our students don't control the startup of the environment itself, so the approach that was there in 0.1.2 was just about right. They could choose which to use, but it's too much for me in class to be telling them to basically reconfigure the server every time they log in. |
I'm already pushing the limits of dog-fooding in a real-world course, I need to keep my focus on actually teaching a class :) |
Though thanks @agoose77 for the |
@fperez so you need the ability to switch off the MyST renderer in some contexts during the same session? Could you elaborate on why you need this, is it just missing features? |
Yup, precisely - the way it worked originally. Right now if there's any bug/mismatch in this renderer compared to the default, escaping out is tricky. I'm using a real-world course to test this, so I need my students to very easily fall-back (within the same session they are working on) to the default renderer at any sign of trouble. |
Are you using |
|
OK. My take (not the only one that matters by any stretch of the imagination) is that the majority of our users at this stage should be using However, I can see that your use case is trickier because of this, so perhaps we can find a compromise; a second, mutually exclusive JupyterLab extension (shipped in this repo) that restores the old behaviour. This would be opt-in for you, so you can configure your binder image such that the old behaviour is the default. |
Yup, I'm happy to do that - I have full control over my hub config so I can add any extension the team offers, as long as it has that functionality. Thx!! |
Other approaches could be:
I think at this stage we are already have I am not sure if (2) is easily possible, but would love to see settings start to emerge in this extension, so that could be a way to get into doing that! |
@rowanc1 on terminology, in the JupyterLab context an "extension" is just a re-usable unit of code that integrates with the dependency injection system. We can ship multiple in the same package. I think we might be able to e.g. trigger a setting, but the user would also need to reload the page. I can see why that would be a poor UX if @fperez wants students to be able to do this multiple times in a session :/ I'll push a PR that we can bikeshed :) |
Ok, awesome. Mostly trying to avoid having more pip/npm/conda packages out there. Looking forward to seeing what you come up with, thanks @agoose77. Let me know when I can help out! |
BTW @rowanc1 is there a feeling that we'll use an organisation package name here, e.g. |
TL;DR: I think we should stick with a flat namespace (no We debated this a lot with the I think there is a different approach if there is a collection of packages that must all be installed together to work, this is the approach that we are taking for |
Fantastic, I'll push to our hub once it's on PyPI and will keep reporting. I immensely appreciate the team's hard work, I'm very excited about working this semester with MyST with our students - thx @agoose77 for the responsiveness! |
Describe the bug
context
For being able to test this extension in a hosted hub, it's critical that I can switch back and forth between the MystJS renderer and a "normal" view with the default one, as was possible til 0.1.2.
If we notice problems with mystjs, right now we have no option but to entirely uninstall it and redeploy into production, which is a huge barrier.
I'm happy to tell students to occasionally switch to the old renderer manually if necessary, but having to redeploy makes it impractical to test/use the tool while it matures in a production environment.
Reproduce the bug
Once installed, mystjs takes over completely all notebook rendering.
List your environment
No response
The text was updated successfully, but these errors were encountered: