Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Myst-vs-code blocks plantuml rendering for code blocks #51

Open
arwedus opened this issue Feb 3, 2023 · 1 comment
Open

Myst-vs-code blocks plantuml rendering for code blocks #51

arwedus opened this issue Feb 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@arwedus
Copy link

arwedus commented Feb 3, 2023

Describe the bug

With the jebbs.plantuml extension and the VS Code internal Markdown preview,
the following code will produce a rendered inline plantUML diagram inside the markdown preview:

# My diagram document

This should render as an inline diagram in VS code markdown preview:

```{uml}
@startuml
A -> B
B -> A
@enduml
```

With myst markdown extension enabled (and myst.preview.enable enabled), the above code block is instead rendered as some text block hovering on the right side of the document preview.

With the setting myst.preview.enable set to false, plantUML code blocks like above are rendered as diagrams again.

To Reproduce

  1. Install extension jebbs.plantuml
  2. Configure the plantuml rendering mode to "server" ("local" rendering in Markdown preview won't work)
  3. Create a new markdown file with the content given above
  4. Open Markdown preview to the side

Expected behavior

myst-vs-code should probably forward all "sphinx directives code blocks" for which it doesn't have any special handling to the default markdown renderer. Especially for directives uml, plantuml. However, there are other directives like mermaid for which there might be a special rendering in VS Code.

Screenshots

Desktop (please complete the following information):

  • OS: Ubuntu 20.04 Linux
  • VS Code Version v1.75.0
  • Myst markdown v0.11.0
@arwedus arwedus added the bug Something isn't working label Feb 3, 2023
@welcome
Copy link

welcome bot commented Feb 3, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant