Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest Octicon icons #180

Closed
MarcSkovMadsen opened this issue Feb 8, 2024 · 3 comments
Closed

Support latest Octicon icons #180

MarcSkovMadsen opened this issue Feb 8, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@MarcSkovMadsen
Copy link

MarcSkovMadsen commented Feb 8, 2024

Context

I am trying to do docs contributions to HoloViz Panel. I notice that something does not work when I use specific Octicon icons in the cards.

In holoviz/panel#6318 I request Panel to support these icons. But I'm told its really Sphinx-Design that do not support them. Sphinx-Design only supports the octicon-icons listed in https://sphinx-design.readthedocs.io/en/latest/badges_buttons.html#octicon-icons

Proposal

Support all Octicon Icons that can be found at https://primer.style/foundations/icons

Not Working

image

@MarcSkovMadsen MarcSkovMadsen added the enhancement New feature or request label Feb 8, 2024
Copy link

welcome bot commented Feb 8, 2024

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

This should be closed by #171, but feel free to re-open if not

@MarcSkovMadsen
Copy link
Author

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants