Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve specificity of JS function name #153

Merged
merged 2 commits into from
Aug 30, 2023
Merged

👌 Improve specificity of JS function name #153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e596458
Fix namespace issue with sphinx-inline-tabs
Aug 14, 2023
5587e22
Merge branch 'main' into fix-namespace-issue
chrisjsewell Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sphinx_design/compiled/sd_tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ function ready() {
for (const label of li) {
syncId = label.getAttribute("data-sync-id");
if (syncId) {
label.onclick = onLabelClick;
label.onclick = onSDLabelClick;
if (!sd_labels_by_text[syncId]) {
sd_labels_by_text[syncId] = [];
}
Expand All @@ -14,7 +14,7 @@ function ready() {
}
}

function onLabelClick() {
function onSDLabelClick() {
// Activate other inputs with the same sync id.
syncId = this.getAttribute("data-sync-id");
for (label of sd_labels_by_text[syncId]) {
Expand Down