Skip to content

Commit 74365a1

Browse files
authored
isbn-verifier: Sync tests (#860)
* sync tests * regenerate tests
1 parent 85ac8cb commit 74365a1

File tree

2 files changed

+18
-11
lines changed

2 files changed

+18
-11
lines changed

exercises/practice/isbn-verifier/.meta/tests.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ description = "invalid character in isbn is not treated as zero"
3030
[28025280-2c39-4092-9719-f3234b89c627]
3131
description = "X is only valid as a check digit"
3232

33+
[fdb14c99-4cf8-43c5-b06d-eb1638eff343]
34+
description = "X is not substituted by the value 10"
35+
3336
[f6294e61-7e79-46b3-977b-f48789a4945b]
3437
description = "valid isbn without separating dashes"
3538

exercises/practice/isbn-verifier/test/isbn_verifier_test.clj

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,49 +31,53 @@
3131
(is (false? (isbn-verifier/isbn? "3-598-2X507-9")))))
3232

3333
(deftest isbn?_test_8
34+
(testing "X is not substituted by the value 10"
35+
(is (false? (isbn-verifier/isbn? "3-598-2X507-5")))))
36+
37+
(deftest isbn?_test_9
3438
(testing "valid isbn without separating dashes"
3539
(is (true? (isbn-verifier/isbn? "3598215088")))))
3640

37-
(deftest isbn?_test_9
41+
(deftest isbn?_test_10
3842
(testing "isbn without separating dashes and X as check digit"
3943
(is (true? (isbn-verifier/isbn? "359821507X")))))
4044

41-
(deftest isbn?_test_10
45+
(deftest isbn?_test_11
4246
(testing "isbn without check digit and dashes"
4347
(is (false? (isbn-verifier/isbn? "359821507")))))
4448

45-
(deftest isbn?_test_11
49+
(deftest isbn?_test_12
4650
(testing "too long isbn and no dashes"
4751
(is (false? (isbn-verifier/isbn? "3598215078X")))))
4852

49-
(deftest isbn?_test_12
53+
(deftest isbn?_test_13
5054
(testing "too short isbn"
5155
(is (false? (isbn-verifier/isbn? "00")))))
5256

53-
(deftest isbn?_test_13
57+
(deftest isbn?_test_14
5458
(testing "isbn without check digit"
5559
(is (false? (isbn-verifier/isbn? "3-598-21507")))))
5660

57-
(deftest isbn?_test_14
61+
(deftest isbn?_test_15
5862
(testing "check digit of X should not be used for 0"
5963
(is (false? (isbn-verifier/isbn? "3-598-21515-X")))))
6064

61-
(deftest isbn?_test_15
65+
(deftest isbn?_test_16
6266
(testing "empty isbn"
6367
(is (false? (isbn-verifier/isbn? "")))))
6468

65-
(deftest isbn?_test_16
69+
(deftest isbn?_test_17
6670
(testing "input is 9 characters"
6771
(is (false? (isbn-verifier/isbn? "134456729")))))
6872

69-
(deftest isbn?_test_17
73+
(deftest isbn?_test_18
7074
(testing "invalid characters are not ignored after checking length"
7175
(is (false? (isbn-verifier/isbn? "3132P34035")))))
7276

73-
(deftest isbn?_test_18
77+
(deftest isbn?_test_19
7478
(testing "invalid characters are not ignored before checking length"
7579
(is (false? (isbn-verifier/isbn? "3598P215088")))))
7680

77-
(deftest isbn?_test_19
81+
(deftest isbn?_test_20
7882
(testing "input is too long but contains a valid isbn"
7983
(is (false? (isbn-verifier/isbn? "98245726788")))))

0 commit comments

Comments
 (0)