From 306aaaf5314998e768674248c0924ad55346fc25 Mon Sep 17 00:00:00 2001 From: devkabiir Date: Thu, 18 Feb 2021 18:56:40 +0530 Subject: [PATCH 1/3] Don't run configlet lint manually in check_formatting.dart --- bin/check_formatting.dart | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/bin/check_formatting.dart b/bin/check_formatting.dart index 60fd995a..f3db724b 100644 --- a/bin/check_formatting.dart +++ b/bin/check_formatting.dart @@ -5,17 +5,6 @@ Future main() async { final CommonUtils utils = CommonUtils(); int errorCode = 0; - if (await utils.fetchConfiglet() == 0) { - print('Checking config.json formatting...'); - errorCode = await utils.runCmdIfExecutable('bin/configlet', ['lint', '--track-id', 'dart', '.']); - - if (errorCode != 0) { - print('Checking config.json formatting failed!!'); - await utils.terminate(); - throw StateError('Formatting failed.'); - } - } - print('Checking all Dart files formatting...'); errorCode = await utils .runCmd('pub', ['run', 'dart_style:format', '-i', '0', '-l', '120', '-n', '--set-exit-if-changed', '.']); From 7fbb0e1bfad7494a07928f0be38c355e8ee6f1cb Mon Sep 17 00:00:00 2001 From: devkabiir Date: Thu, 18 Feb 2021 20:04:10 +0530 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=90=9B=20=20(exercises/concepts)=20Ad?= =?UTF-8?q?d=20stub=20content=20to=20dart=20files?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is to allow dart formatting checks to pass in CI --- exercises/concept/futures/lib/futures.dart | 1 + exercises/concept/numbers/lib/numbers.dart | 1 + exercises/concept/strings/lib/strings.dart | 1 + 3 files changed, 3 insertions(+) diff --git a/exercises/concept/futures/lib/futures.dart b/exercises/concept/futures/lib/futures.dart index e69de29b..70b786d1 100644 --- a/exercises/concept/futures/lib/futures.dart +++ b/exercises/concept/futures/lib/futures.dart @@ -0,0 +1 @@ +// TODO diff --git a/exercises/concept/numbers/lib/numbers.dart b/exercises/concept/numbers/lib/numbers.dart index e69de29b..70b786d1 100644 --- a/exercises/concept/numbers/lib/numbers.dart +++ b/exercises/concept/numbers/lib/numbers.dart @@ -0,0 +1 @@ +// TODO diff --git a/exercises/concept/strings/lib/strings.dart b/exercises/concept/strings/lib/strings.dart index e69de29b..70b786d1 100644 --- a/exercises/concept/strings/lib/strings.dart +++ b/exercises/concept/strings/lib/strings.dart @@ -0,0 +1 @@ +// TODO From 0f7c40463fee88c2d28d73756d13563b2777456d Mon Sep 17 00:00:00 2001 From: devkabiir Date: Thu, 18 Feb 2021 20:10:41 +0530 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=9A=A7=20=20(presubmit)=20Temporarily?= =?UTF-8?q?=20disable=20`configlet=20fmt`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Please see https://github.com/exercism/dart/issues/296 --- bin/presubmit.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/presubmit.dart b/bin/presubmit.dart index 910988db..8f2b00b3 100644 --- a/bin/presubmit.dart +++ b/bin/presubmit.dart @@ -6,7 +6,8 @@ Future main() async { if (await utils.fetchConfiglet() == 0) { print('Formatting config.json...'); - await utils.runCmdIfExecutable('bin/configlet', ['fmt', '.']); + print('Unsupported operation: Please see https://github.com/exercism/dart/issues/296'); + // await utils.runCmdIfExecutable('bin/configlet', ['fmt', '.']); } print('Formatting all Dart files...');