Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1528 ] Remove mentions and uses of unless #1539

Merged
merged 3 commits into from
Dec 9, 2024
Merged

[#1528 ] Remove mentions and uses of unless #1539

merged 3 commits into from
Dec 9, 2024

Conversation

jiegillet
Copy link
Contributor

Closes #1528

It's a bit unfortunate that some links (like https://hexdocs.pm/elixir/case-cond-and-if.html#if-unless) mention unless in the hash, but it'll be a quick fix. We could also wait for 1.18 before merging this.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?
  • Concept changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <concept>/.meta/config.json (see docs)?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

@@ -2,7 +2,7 @@

## General

- Read about `if` in the official [Getting Started guide][getting-started-if-unless] or on [elixirschool.com][elixirschool-if-unless].
- Read about `if` in the official [Getting Started guide][getting-started-if] or on [elixirschool.com][elixirschool-if].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Elixir School links was broken

@angelikatyborska
Copy link
Member

I'm fine with either merging it right now and then creating a new ticket to update the hash locations in the docs to the new ones without unless (looks like it will be https://hexdocs.pm/elixir/main/case-cond-and-if.html#if). Or just keep this PR open until 1.18 is released and update the links before merging. Whichever you prefer 🙂

@jiegillet
Copy link
Contributor Author

I think we can merge it, I can write an update on the ticket open and keep it open.
It's probably the same amount of work to do the change on main than on this branch. Plus, if we keep even one person from looking up unless, it's worth it :)

@jiegillet jiegillet merged commit a6e44e8 into main Dec 9, 2024
8 of 9 checks passed
@jiegillet jiegillet deleted the jie-unless branch December 9, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate unless in Elixir 1.18
2 participants