From d896ddf1db19ffd6bcd8ef271a14dfc2e00612d6 Mon Sep 17 00:00:00 2001
From: Katrina Owen <katrina.owen@gmail.com>
Date: Mon, 23 Jan 2023 08:20:29 +0100
Subject: [PATCH] Tweak pangram tests per canonical-data

This removes an include=false from the tests.toml, as the
exclusion seems to have been unintentional (the new test
passes with no changes to the example solution).

It also switches to use the should.be_false / should.be_true style
that other tests use, rather than assert False / assert True.
---
 exercises/practice/pangram/.meta/config.json  |  3 ++
 exercises/practice/pangram/.meta/tests.toml   |  1 -
 .../practice/pangram/test/pangram_test.gleam  | 38 ++++++++++++-------
 3 files changed, 28 insertions(+), 14 deletions(-)

diff --git a/exercises/practice/pangram/.meta/config.json b/exercises/practice/pangram/.meta/config.json
index df30c8386..33b268407 100644
--- a/exercises/practice/pangram/.meta/config.json
+++ b/exercises/practice/pangram/.meta/config.json
@@ -2,6 +2,9 @@
   "authors": [
     "lpil"
   ],
+  "contributors": [
+    "kytrinyx"
+  ],
   "files": {
     "solution": [
       "src/pangram.gleam"
diff --git a/exercises/practice/pangram/.meta/tests.toml b/exercises/practice/pangram/.meta/tests.toml
index 10b5a335a..0d2ea2b00 100644
--- a/exercises/practice/pangram/.meta/tests.toml
+++ b/exercises/practice/pangram/.meta/tests.toml
@@ -38,7 +38,6 @@ description = "mixed case and punctuation"
 
 [2577bf54-83c8-402d-a64b-a2c0f7bb213a]
 description = "case insensitive"
-include = false
 
 [7138e389-83e4-4c6e-8413-1e40a0076951]
 description = "a-m and A-M are 26 different characters but not a pangram"
diff --git a/exercises/practice/pangram/test/pangram_test.gleam b/exercises/practice/pangram/test/pangram_test.gleam
index 562f47ef7..e8816742e 100644
--- a/exercises/practice/pangram/test/pangram_test.gleam
+++ b/exercises/practice/pangram/test/pangram_test.gleam
@@ -1,5 +1,6 @@
 import pangram.{is_pangram}
 import gleeunit
+import gleeunit/should
 
 pub fn main() {
   gleeunit.main()
@@ -7,55 +8,66 @@ pub fn main() {
 
 pub fn empty_sentence_test() {
   let sentence = ""
-  assert False = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_false
 }
 
 pub fn perfect_lower_case_test() {
   let sentence = "abcdefghijklmnopqrstuvwxyz"
-  assert True = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_true
 }
 
 pub fn only_lower_case_test() {
   let sentence = "the quick brown fox jumps over the lazy dog"
-  assert True = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_true
 }
 
 pub fn missing_the_letter_x_test() {
   let sentence = "a quick movement of the enemy will jeopardize five gunboats"
-  assert False = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_false
 }
 
 pub fn missing_the_letter_h_test() {
   let sentence = "five boxing wizards jump quickly at it"
-  assert False = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_false
 }
 
 pub fn with_underscores_test() {
   let sentence = "the_quick_brown_fox_jumps_over_the_lazy_dog"
-  assert True = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_true
 }
 
 pub fn with_numbers_test() {
   let sentence = "the 1 quick brown fox jumps over the 2 lazy dogs"
-  assert True = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_true
 }
 
 pub fn missing_letters_replaced_by_numbers_test() {
   let sentence = "7h3 qu1ck brown fox jumps ov3r 7h3 lazy dog"
-  assert False = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_false
 }
 
 pub fn mixed_case_and_punctuation_test() {
-  let sentence = "Five quacking Zephyrs jolt my wax bed."
-  assert True = is_pangram(sentence)
+  let sentence = "\"Five quacking Zephyrs jolt my wax bed.\""
+  is_pangram(sentence)
+  |> should.be_true
 }
 
 pub fn case_insensitive_test() {
   let sentence = "the quick brown fox jumps over with lazy FX"
-  assert False = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_false
 }
 
-pub fn a_m_and_upper_a_m_are_26_different_characters_but_not_a_pangram_test() {
+pub fn a_m_and_a_m_are_26_different_characters_but_not_a_pangram_test() {
   let sentence = "abcdefghijklm ABCDEFGHIJKLM"
-  assert False = is_pangram(sentence)
+  is_pangram(sentence)
+  |> should.be_false
 }