Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Run FFMPEG without a terminal windows opening up #103

Closed
Plastermaster opened this issue May 3, 2024 · 8 comments
Closed

[Feature] Run FFMPEG without a terminal windows opening up #103

Plastermaster opened this issue May 3, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@Plastermaster
Copy link

Current Situation

Currently, with FFMPEG added in the settings for the conversion, it's opening a new window for a split second after each download. This results in the window focus to be disturbed as now the terminal (I assume CMD here) is taking over the window focus, but it's not always returning the focus to the previously focused window, interrupting use of the computer, especially during larger downloads of full playlists.

Suggestion / Feature Request

If possible, it would be convenient if the use of FFMPEG didn't cause a visible window to show up at all and simply run in the background.

@Plastermaster Plastermaster added the enhancement New feature or request label May 3, 2024
@Plastermaster
Copy link
Author

Looking around I've found this possible solution, but I don't know how much this might disrupt the current structure of the program. kkroening/ffmpeg-python#686 (comment)
https://stackoverflow.com/questions/62968888/how-to-hide-console-output-of-ffmpeg-in-python/71741286#71741286

@exislow
Copy link
Owner

exislow commented May 4, 2024

What OS are you seeing this baviour on?

@Plastermaster
Copy link
Author

What OS are you seeing this baviour on?

I'm on windows 11, 23H2

@exislow
Copy link
Owner

exislow commented May 15, 2024

I do not use Windows, though it's hard for me to debug this. But the proposed solution is rather high maintenance. I do not feel comfortable with overwriting external library code. This means, I need to track every change of the library. Maybe there is a simpler solution.

@exislow
Copy link
Owner

exislow commented May 21, 2024

I have applied this suggestion: https://stackoverflow.com/a/76146125

Please check, if this helps. If not, please also re-open this issue.

@MEIDUNN
Copy link

MEIDUNN commented Jul 24, 2024

I have applied this suggestion: https://stackoverflow.com/a/76146125

Please check, if this helps. If not, please also re-open this issue.

Does not seem to have fixed it. Still pops up for me.

@grimsandwich
Copy link

I think this method might work better, running it in subprocess without windows:
https://stackoverflow.com/a/65719601

@exislow
Copy link
Owner

exislow commented Nov 11, 2024

The used library ffmpeg-python needs to be changed as suggested here: https://stackoverflow.com/a/74931189

Maybe you can raise an issue regarding that over there at the ffmpeg-python repo or you could try to follow up this one kkroening/ffmpeg-python#805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants