Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample code in README outdated #27

Open
elie222 opened this issue Apr 17, 2022 · 2 comments
Open

Sample code in README outdated #27

elie222 opened this issue Apr 17, 2022 · 2 comments

Comments

@elie222
Copy link
Contributor

elie222 commented Apr 17, 2022

We updated the codebase with a fix for owner withdrawing all funds but didn't update the README sample code to match this
@lawweiliang
Copy link
Contributor

Noted. Thanks @elie222.

I am working on something to minimize the cost of ERC721R. You will be surprise. 😄

@elie222
Copy link
Contributor Author

elie222 commented Apr 18, 2022

Awesome. I will try get README update in today as it's quite important and confusing to people right now (it has the bug in it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elie222 @lawweiliang