Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refund event and IERC721R interface #31

Open
elie222 opened this issue Apr 21, 2022 · 7 comments
Open

Refund event and IERC721R interface #31

elie222 opened this issue Apr 21, 2022 · 7 comments

Comments

@elie222
Copy link
Contributor

elie222 commented Apr 21, 2022

Wonder if we add a Refund event. Probably helpful to have.

Also thinking about the interface as a whole. Perhaps something like this with Refund event:

interface IERC721R {
    function refund(uint256[] calldata tokenIds) external;

    function getRefundPrice(uint256 tokenId) external view returns (uint256);

    function getRefundGuaranteeEndTime() external view returns (uint256);

    function isRefundGuaranteeActive() external view returns (bool);
}

Anything else we may want here?

@elie222 elie222 changed the title Refund event Refund event and IERC721R interface Apr 21, 2022
@lawweiliang
Copy link
Contributor

lawweiliang commented Apr 21, 2022

@elie222 Yeah, refund event is needed.


Aside from that
I think all these functions need events as well

image

Why?

Easy for frontend to track they are successfully call the function.

@elie222
Copy link
Contributor Author

elie222 commented Apr 21, 2022

Adding these to the CF contract. Can add into the main repo after 👍

@lawweiliang
Copy link
Contributor

@elie222 , do you need help on this? Offer to help. 😄

@elie222
Copy link
Contributor Author

elie222 commented Apr 21, 2022

We have a developer working on it in any case. The most help may be around this PR if you notice anything wrong:
#32

@lawweiliang
Copy link
Contributor

Alright, I take a look.

@sturench
Copy link

Status?

@elie222
Copy link
Contributor Author

elie222 commented May 15, 2022

We used IERC721R for CryptoFighters Alliance:
https://etherscan.io/address/0x06daf7e34595f9d3260dd5262dca8e3bcfeb39d5#code

Will look to move the latest code into this repo later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants