Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark performance of starry rotation matrices #19

Open
dfm opened this issue Mar 2, 2023 · 0 comments
Open

Benchmark performance of starry rotation matrices #19

dfm opened this issue Mar 2, 2023 · 0 comments
Labels
⭐ starry Discussions about starry development

Comments

@dfm
Copy link
Member

dfm commented Mar 2, 2023

The rotation matrices are block diagonal and in the implementation in #17, the full dense matrix is constructed. This probably isn't what we want in all cases: for larger systems we might want to manually implement the matrix product. That being said, if we're using GPU acceleration, we may want to use the direct solve up to fairly high order. We should benchmark this on several different systems to select sensible defaults and give advice to users.

@dfm dfm added the ⭐ starry Discussions about starry development label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ starry Discussions about starry development
Projects
Status: Todo
Development

No branches or pull requests

1 participant