constants and review comments

exoscale · Oct 11, 2024 · 3767467 · 3767467
1 parent 6fc3185
commit 3767467
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 17 deletions.
diff --git a/cmd/dbaas_external_endpoint_create.go b/cmd/dbaas_external_endpoint_create.go
@@ -92,15 +92,15 @@ func (c *dbaasExternalEndpointCreateCmd) cmdShort() string {
 
 func (c *dbaasExternalEndpointCreateCmd) cmdRun(cmd *cobra.Command, args []string) error {
 	switch c.Type {
-	case "datadog":
+	case ExternalEndpointTypeDatadog:
 		return c.createDatadog(cmd, args)
-	case "opensearch":
+	case ExternalEndpointTypeOpensearch:
 		return c.createOpensearch(cmd, args)
-	case "elasticsearch":
+	case ExternalEndpointTypeElasticsearch:
 		return c.createElasticsearch(cmd, args)
-	case "prometheus":
+	case ExternalEndpointTypePrometheus:
 		return c.createPrometheus(cmd, args)
-	case "rsyslog":
+	case ExternalEndpointTypeRsyslog:
 		return c.createRsyslog(cmd, args)
 	default:
 		return fmt.Errorf("unsupported external endpoint type %q", c.Type)

diff --git a/cmd/dbaas_external_endpoint_show.go b/cmd/dbaas_external_endpoint_show.go
@@ -6,6 +6,14 @@ import (
 	"github.com/spf13/cobra"
 )
 
+const (
+	ExternalEndpointTypeDatadog       = "datadog"
+	ExternalEndpointTypeOpensearch    = "opensearch"
+	ExternalEndpointTypeElasticsearch = "elasticsearch"
+	ExternalEndpointTypePrometheus    = "prometheus"
+	ExternalEndpointTypeRsyslog       = "rsyslog"
+)
+
 type dbaasExternalEndpointShowCmd struct {
 	cliCommandSettings `cli-cmd:"-"`
 
@@ -30,17 +38,16 @@ func (c *dbaasExternalEndpointShowCmd) cmdPreRun(cmd *cobra.Command, args []stri
 }
 
 func (c *dbaasExternalEndpointShowCmd) cmdRun(cmd *cobra.Command, args []string) error {
-
 	switch c.Type {
-	case "datadog":
+	case ExternalEndpointTypeDatadog:
 		return c.outputFunc(c.showDatadog())
-	case "opensearch":
+	case ExternalEndpointTypeOpensearch:
 		return c.outputFunc(c.showOpensearch())
-	case "elasticsearch":
+	case ExternalEndpointTypeElasticsearch:
 		return c.outputFunc(c.showElasticsearch())
-	case "prometheus":
+	case ExternalEndpointTypePrometheus:
 		return c.outputFunc(c.showPrometheus())
-	case "rsyslog":
+	case ExternalEndpointTypeRsyslog:
 		return c.outputFunc(c.showRsyslog())
 	default:
 		return fmt.Errorf("unsupported external endpoint type %q", c.Type)

diff --git a/cmd/dbaas_external_endpoint_update.go b/cmd/dbaas_external_endpoint_update.go
@@ -92,15 +92,15 @@ func (c *dbaasExternalEndpointUpdateCmd) cmdShort() string {
 
 func (c *dbaasExternalEndpointUpdateCmd) cmdRun(cmd *cobra.Command, args []string) error {
 	switch c.Type {
-	case "datadog":
+	case ExternalEndpointTypeDatadog:
 		return c.updateDatadog(cmd, args)
-	case "opensearch":
+	case ExternalEndpointTypeOpensearch:
 		return c.updateOpensearch(cmd, args)
-	case "elasticsearch":
+	case ExternalEndpointTypeElasticsearch:
 		return c.updateElasticsearch(cmd, args)
-	case "prometheus":
+	case ExternalEndpointTypePrometheus:
 		return c.updatePrometheus(cmd, args)
-	case "rsyslog":
+	case ExternalEndpointTypeRsyslog:
 		return c.updateRsyslog(cmd, args)
 	default:
 		return fmt.Errorf("unsupported external endpoint type %q", c.Type)

diff --git a/cmd/dbaas_external_integration_settings_show.go b/cmd/dbaas_external_integration_settings_show.go
@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"fmt"
+
 	"github.com/spf13/cobra"
 )
 
@@ -27,7 +28,7 @@ func (c *dbaasExternalIntegrationSettingsShowCmd) cmdPreRun(cmd *cobra.Command,
 
 func (c *dbaasExternalIntegrationSettingsShowCmd) cmdRun(_ *cobra.Command, _ []string) error {
 	switch c.Type {
-	case "datadog":
+	case ExternalEndpointTypeDatadog:
 		return c.outputFunc(c.showDatadog())
 	default:
 		return fmt.Errorf("unsupported external integration settings for type %q", c.Type)