Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instance reset wrong default template #528

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

PhilippeChepy
Copy link
Member

@PhilippeChepy PhilippeChepy commented Aug 10, 2023

Instance reset was setting the instance base template to account default instead of the current instance template.

Before the fix, if I reset a debian instance with my local settings, it was using ubuntu after reset.
Now it sticks to debian, as expected.

❯ go run main.go compute instance reset -z de-fra-1 VM-b4235265-75e5-4c04-8d03-86dc35914c9f
[+] Are you sure you want to reset instance "VM-b4235265-75e5-4c04-8d03-86dc35914c9f"? [yN]: y
 ✔ Resetting instance "VM-b4235265-75e5-4c04-8d03-86dc35914c9f"... 15s
┼──────────────────────┼─────────────────────────────────────────┼
│   COMPUTE INSTANCE   │                                         │
┼──────────────────────┼─────────────────────────────────────────┼
│ ID                   │ b4235265-75e5-4c04-8d03-86dc35914c9f    │
│ Name                 │ VM-b4235265-75e5-4c04-8d03-86dc35914c9f │
│ Creation Date        │ 2023-08-09 07:53:59 +0000 UTC           │
│ Instance Type        │ standard.micro                          │
│ Template             │ Linux Debian 12 (Bookworm) 64-bit       │
│ Zone                 │ de-fra-1                                │
│ Anti-Affinity Groups │ n/a                                     │
│ Deploy Target        │ -                                       │
│ Security Groups      │ default                                 │
│ Private Instance     │ No                                      │
│ Private Networks     │ n/a                                     │
│ Elastic IPs          │ n/a                                     │
│ IP Address           │ 194.182.168.81                          │
│ IPv6 Address         │ -                                       │
│ SSH Key              │ core-management                         │
│ Disk Size            │ 50 GiB                                  │
│ State                │ running                                 │
│ Labels               │ n/a                                     │
│ Reverse DNS          │                                         │
┼──────────────────────┼─────────────────────────────────────────┼

@shortcut-integration
Copy link

@PhilippeChepy PhilippeChepy force-pushed the pchepy/sc-71574/instance-reset-template branch from c06c999 to 8991d1c Compare August 10, 2023 12:03
Copy link
Contributor

@arnaudgeiser arnaudgeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PhilippeChepy PhilippeChepy force-pushed the pchepy/sc-71574/instance-reset-template branch from 8991d1c to f374bb9 Compare August 10, 2023 12:07
@PhilippeChepy PhilippeChepy merged commit cc17ea1 into master Aug 10, 2023
1 check passed
@PhilippeChepy PhilippeChepy deleted the pchepy/sc-71574/instance-reset-template branch August 10, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants