Compute: Add Block Storage #574

pierre-emmanuelJ · 2024-02-14T16:07:27Z

Description

Add all the Block Storage integration into compute command exo compute block-storage.
Some misc has been added to outputer, to make better integration with our Exoscale API resources (egoscale v3).
Compute instance can create an instance with an attached block storage volume.

Checklist

(For exoscale contributors)

Changelog updated (under Unreleased block)
Testing

Testing

Block Storage create

exo compute block-storage create test-volume --size 100
 ✔ Creating block storage volume "test-volume"... 3s
┼─────────────────────────┼──────────────────────────────────────┼
│  BLOCK STORAGE VOLUME   │                                      │
┼─────────────────────────┼──────────────────────────────────────┼
│ Block Storage Snapshots │ n/a                                  │
│ Blocksize               │ 4096                                 │
│ Created AT              │ 2024-02-20 16:43:32 +0000 UTC        │
│ ID                      │ e429973e-c499-4f66-a64e-a22aa673c32b │
│ Instance                │ n/a                                  │
│ Labels                  │ n/a                                  │
│ Name                    │ test-volume                          │
│ Size                    │ 100 GiB                              │
│ State                   │ detached                             │
┼─────────────────────────┼──────────────────────────────────────┼

Block Storage list

exo compute block-storage list
┼──────────────────────────────────────┼──────────────────┼──────────┼─────────┼──────────┼
│                  ID                  │       NAME       │   ZONE   │  SIZE   │  STATE   │
┼──────────────────────────────────────┼──────────────────┼──────────┼─────────┼──────────┼
│ e429973e-c499-4f66-a64e-a22aa673c32b │ test-volume      │ ch-gva-2 │ 100 GiB │ detached │
│ d441b79f-96dd-453c-8e49-6fbb8781443b │ test-volume-prod │ ch-gva-2 │ 400 GiB │ detached │
┼──────────────────────────────────────┼──────────────────┼──────────┼─────────┼──────────┼

Block Storage attach

exo compute block-storage attach test-volume test-instance
 ✔ Attaching volume "test-volume" to instance "test-instance"... 3s

Block Storage Snapshot create

exo compute block-storage snapshot create test-volume
 ✔ Snapshoting block storage volume "test-volume"... 3s
┼───────────────────────────────┼──────────────────────────────────────┼
│ BLOCK STORAGE VOLUME SNAPSHOT │                                      │
┼───────────────────────────────┼──────────────────────────────────────┼
│ Created AT                    │ 2024-02-20 16:49:37 +0000 UTC        │
│ ID                            │ 448657be-9a2d-4f58-b15d-47f2216faadd │
│ Labels                        │ n/a                                  │
│ Volume                        │ e429973e-c499-4f66-a64e-a22aa673c32b │
│ Name                          │ test-volume_20240220164937           │
│ Size                          │ 0 B                                  │
│ State                         │ created                              │
┼───────────────────────────────┼──────────────────────────────────────┼

Block Storage Snapshot list

exo compute block-storage snapshot list
┼──────────────────────────────────────┼─────────────────────────────────┼──────────┼──────────────────────────────────────┼
│                  ID                  │              NAME               │   ZONE   │                VOLUME                │
┼──────────────────────────────────────┼─────────────────────────────────┼──────────┼──────────────────────────────────────┼
│ 45b75214-29b9-4e35-99f4-09d7777f96ab │ test-volume_20240220165017      │ ch-gva-2 │ e429973e-c499-4f66-a64e-a22aa673c32b │
│ 7058af47-51b7-4ce6-b0ba-f7ccdc6ce880 │ test-volume-prod_20240220165009 │ ch-gva-2 │ d441b79f-96dd-453c-8e49-6fbb8781443b │
│ 448657be-9a2d-4f58-b15d-47f2216faadd │ test-volume_20240220164937      │ ch-gva-2 │ e429973e-c499-4f66-a64e-a22aa673c32b │
┼──────────────────────────────────────┼─────────────────────────────────┼──────────┼──────────────────────────────────────┼

Block Storage Snapshot show

exo compute block-storage snapshot show test-volume_20240220165017
┼───────────────────────────────┼──────────────────────────────────────┼
│ BLOCK STORAGE VOLUME SNAPSHOT │                                      │
┼───────────────────────────────┼──────────────────────────────────────┼
│ Created AT                    │ 2024-02-20 16:50:17 +0000 UTC        │
│ ID                            │ 45b75214-29b9-4e35-99f4-09d7777f96ab │
│ Labels                        │ n/a                                  │
│ Volume                        │ e429973e-c499-4f66-a64e-a22aa673c32b │
│ Name                          │ test-volume_20240220165017           │
│ Size                          │ 0 B                                  │
│ State                         │ created                              │
┼───────────────────────────────┼──────────────────────────────────────┼

Block Storage show

exo compute block-storage show test-volume
┼─────────────────────────┼──────────────────────────────────────┼
│  BLOCK STORAGE VOLUME   │                                      │
┼─────────────────────────┼──────────────────────────────────────┼
│ Block Storage Snapshots │ 45b75214-29b9-4e35-99f4-09d7777f96ab │
│                         │ 448657be-9a2d-4f58-b15d-47f2216faadd │
│ Blocksize               │ 4096                                 │
│ Created AT              │ 2024-02-20 16:43:32 +0000 UTC        │
│ ID                      │ e429973e-c499-4f66-a64e-a22aa673c32b │
│ Instance                │ 22ffc858-ea8b-4896-9e86-4ac1ee18afaf │
│ Labels                  │ n/a                                  │
│ Name                    │ test-volume                          │
│ Size                    │ 100 GiB                              │
│ State                   │ attached                             │
┼─────────────────────────┼──────────────────────────────────────┼

Block Storage Snapshot delete

exo compute block-storage snapshot delete test-volume_20240220165017
[+] Are you sure you want to delete block storage volume snapshot "test-volume_20240220165017"? [yN]: y
 ✔ Deleting block storage volume snapshot "test-volume_20240220165017"... 3s

Block Storage detach

exo compute block-storage detach test-volume
[+] Are you sure you want to detach block storage volume "test-volume"? [yN]: y
 ✔ Detaching block storage volume "test-volume"... 3s

Block Storage delete

exo compute block-storage delete test-volume
[+] Are you sure you want to delete block storage volume "test-volume"? [yN]: y
 ✔ Deleting block storage volume "test-volume"... 3s

Create Instance from Block Storage Volume

exo compute instance create instance-test --block-storage-volume test-volume-prod
 ✔ Creating instance "instance-test"... 16s
┼──────────────────────┼──────────────────────────────────────┼
│   COMPUTE INSTANCE   │                                      │
┼──────────────────────┼──────────────────────────────────────┼
│ ID                   │ b8fa9558-da71-41be-8007-ce41612f7294 │
│ Name                 │ instance-test                        │
│ Creation Date        │ 2024-02-20 17:17:23 +0000 UTC        │
│ Instance Type        │ standard.medium                      │
│ Template             │ Linux Ubuntu 22.04 LTS 64-bit        │
│ Zone                 │ ch-gva-2                             │
│ Anti-Affinity Groups │ n/a                                  │
│ Deploy Target        │ -                                    │
│ Security Groups      │ default                              │
│ Private Instance     │ No                                   │
│ Private Networks     │ n/a                                  │
│ Elastic IPs          │ n/a                                  │
│ IP Address           │x.x.x.x                         │
│ IPv6 Address         │ -                                    │
│ SSH Key              │ -                                    │
│ Disk Size            │ 50 GiB                               │
│ State                │ running                              │
│ Labels               │ n/a                                  │
│ Reverse DNS          │                                      │
┼──────────────────────┼──────────────────────────────────────┼

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

…ockstorage-integration-on-the-cli

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

sauterp

It's a big PR, if you could have split it it would be easier to review. I'll review more later.

cmd/blockstorage_attach.go

cmd/blockstorage_create.go

cmd/blockstorage_delete.go

cmd/blockstorage_detach.go

cmd/blockstorage_attach.go

cmd/blockstorage_detach.go

cmd/blockstorage_list.go

cmd/blockstorage_show.go

cmd/blockstorage_snapshot_create.go

cmd/blockstorage_snapshot_delete.go

cmd/blockstorage_snapshot_show.go

cmd/blockstorage_update.go

cmd/instance_create.go

Co-authored-by: Philipp Sauter <[email protected]>

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

cmd/blockstorage_snapshot_create.go

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

…ockstorage-integration-on-the-cli Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

cmd/blockstorage_create.go

cmd/instance_create.go

cmd/blockstorage_update.go

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ added 3 commits February 13, 2024 10:34

Update vendor

6ec1030

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Update vendor

5030cc6

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Add skeleton

835f4a2

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ added the WIP 🚧 Work in progress label Feb 14, 2024

exoscale deleted a comment from shortcut-integration bot Feb 14, 2024

pierre-emmanuelJ added 12 commits February 14, 2024 17:13

Add some logic egoscale v3

fb19b2e

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Add first test

6b39c5b

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Add findable resource

253ee2a

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Add list get create

ab3c97d

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Add delete

92e4f64

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Add more features

04ae67e

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

BS cruds finished without snapshot

650505b

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Finished snapshots

c9087cc

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Add vm creation with block storage attach

4131100

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

fix suspicious identical LHS and RHS for !=

de12831

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Merge branch 'master' of github.com:exoscale/cli into pej/sc-78479/bl…

51a8405

…ockstorage-integration-on-the-cli

Update change log

c98ee10

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ marked this pull request as ready for review February 20, 2024 17:26

pierre-emmanuelJ requested review from sauterp and kobajagi February 20, 2024 17:26

pierre-emmanuelJ removed the WIP 🚧 Work in progress label Feb 20, 2024

pierre-emmanuelJ changed the title ~~Add upcoming Block Storage~~ Add Block Storage Feb 20, 2024

pierre-emmanuelJ requested a review from brutasse February 20, 2024 17:35

pierre-emmanuelJ changed the title ~~Add Block Storage~~ Compute: Add Block Storage Feb 20, 2024

Add update volume command

30c0172

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ force-pushed the pej/sc-78479/blockstorage-integration-on-the-cli branch from 174b838 to 30c0172 Compare February 21, 2024 11:08

sauterp reviewed Feb 21, 2024

View reviewed changes

cmd/instance_create.go Outdated Show resolved Hide resolved

Update cmd/blockstorage_attach.go

3299926

Co-authored-by: Philipp Sauter <[email protected]>

pierre-emmanuelJ and others added 6 commits February 22, 2024 09:47

Update cmd/blockstorage_snapshot_list.go

7fb8f9c

Co-authored-by: Philipp Sauter <[email protected]>

Update cmd/blockstorage_update.go

d526ece

Co-authored-by: Philipp Sauter <[email protected]>

Update cmd/blockstorage_update.go

eb4564d

Co-authored-by: Philipp Sauter <[email protected]>

Rename from Blockstorage to BlockStorage

8ad84de

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Remove labels support in update cmd

54320f7

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Refacto error in instance create with BS

8d3fd57

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ requested a review from sauterp March 1, 2024 13:40

pierre-emmanuelJ added 4 commits March 5, 2024 14:31

Support endpoint for other environment than prod

fc482eb

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Typo on attach cmd

a43a431

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Update bs create default size

0df5c68

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Remove labels

b1f5e32

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ commented Mar 7, 2024

View reviewed changes

cmd/blockstorage_snapshot_create.go Outdated Show resolved Hide resolved

Remove label for snapshot

be545b2

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ added the HOLD ✋ Hold, don't merge label Mar 8, 2024

pierre-emmanuelJ added 2 commits March 28, 2024 13:28

Merge branch 'master' of github.com:exoscale/cli into pej/sc-78479/bl…

aa6569a

…ockstorage-integration-on-the-cli Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Update vendor

6cf84fe

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

arnaudgeiser approved these changes Mar 28, 2024

View reviewed changes

Update for the new API GiB output

9aba3c2

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ requested a review from arnaudgeiser March 28, 2024 13:59

arnaudgeiser approved these changes Mar 28, 2024

View reviewed changes

pierre-emmanuelJ removed the HOLD ✋ Hold, don't merge label Apr 2, 2024

kobajagi approved these changes Apr 2, 2024

View reviewed changes

sauterp reviewed Apr 2, 2024

View reviewed changes

cmd/blockstorage_create.go Outdated Show resolved Hide resolved

cmd/instance_create.go Outdated Show resolved Hide resolved

cmd/blockstorage_update.go Show resolved Hide resolved

sauterp approved these changes Apr 2, 2024

View reviewed changes

pierre-emmanuelJ added 4 commits April 2, 2024 13:40

Add a warning before display BS volume if an error on a zone

8040924

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

todo name

505c586

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Remove bs in create instance

c0b85e7

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

Fix alias

5702fe6

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

pierre-emmanuelJ merged commit aadbe20 into master Apr 3, 2024
1 check passed

pierre-emmanuelJ deleted the pej/sc-78479/blockstorage-integration-on-the-cli branch April 3, 2024 09:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compute: Add Block Storage #574

Compute: Add Block Storage #574

pierre-emmanuelJ commented Feb 14, 2024 •

edited

Loading

sauterp left a comment

Compute: Add Block Storage #574

Compute: Add Block Storage #574

Conversation

pierre-emmanuelJ commented Feb 14, 2024 • edited Loading

Description

Checklist

Testing

Block Storage create

Block Storage list

Block Storage attach

Block Storage Snapshot create

Block Storage Snapshot list

Block Storage Snapshot show

Block Storage show

Block Storage Snapshot delete

Block Storage detach

Block Storage delete

Create Instance from Block Storage Volume

sauterp left a comment

Choose a reason for hiding this comment

pierre-emmanuelJ commented Feb 14, 2024 •

edited

Loading