Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Create: Migrate to egoscale v3 and add multiple sshkeys #620

Merged

Conversation

pierre-emmanuelJ
Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ commented Jul 15, 2024

Description

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

go run main.go c i create test-instance \ 
             -z de-fra-1 \
             --anti-affinity-group b2dbf427-251d-404e-83a4-ee804c9fcc04 \
             --cloud-init ~/cloud.yaml \
             --disk-size 100 \
             --instance-type standard.small \
             --ipv6 \
             --label test=toto \
             --private-network fbc1093c-53eb-46cf-a5b6-5cc4c7ac9cc4 \
             --security-group vpn \
             --ssh-key pierro777 \
             --ssh-key test1-1721039696 \
             --ssh-key test1-1721044660 \
             --template "Linux Debian 12 (Bookworm) 64-bit" \
             --template-visibility public

 ✔ Creating instance "test-instance"... 21s
┼──────────────────────┼──────────────────────────────────────┼
│   COMPUTE INSTANCE   │                                      │
┼──────────────────────┼──────────────────────────────────────┼
│ ID                   │ c1926e55-7bb9-4678-84aa-444e994c41bc │
│ Name                 │ test-instance                        │
│ Creation Date        │ 2024-07-24 09:16:24 +0000 UTC        │
│ Instance Type        │ standard.small                       │
│ Template             │ Linux Debian 12 (Bookworm) 64-bit    │
│ Zone                 │ de-fra-1                             │
│ Anti-Affinity Groups │ test                                 │
│ Deploy Target        │ -                                    │
│ Security Groups      │ vpn                                  │
│ Private Instance     │ No                                   │
│ Private Networks     │ test                                 │
│ Elastic IPs          │ n/a                                  │
│ IP Address           │ 89.145.161.94                        │
│ IPv6 Address         │ 2a04:c46:e00:82a1:473:88ff:fe00:12c  │
│ SSH Key              │ pierro777                            │
│ Disk Size            │ 100 GiB                              │
│ State                │ running                              │
│ Labels               │ test:toto                            │
│ Reverse DNS          │                                      │
┼──────────────────────┼──────────────────────────────────────┼

I made multiple test like that with all the flags, and private instance also has been tested, since it's slightly different.
I can confirm multiple ssh keys are working (pub keys are present on the instance). To show multiple ssh keys, instance show need to be adapted with egoscale v3 also, but will be done in another PR

…oling-support-for-multiple-ssh-keys

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
@pierre-emmanuelJ pierre-emmanuelJ marked this pull request as ready for review July 22, 2024 13:07
@pierre-emmanuelJ pierre-emmanuelJ requested a review from a team July 22, 2024 13:07
Copy link
Member

@sauterp sauterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite a lot of changes, how did you test it?

cmd/instance_create.go Outdated Show resolved Hide resolved
cmd/instance_create.go Outdated Show resolved Hide resolved
pierre-emmanuelJ and others added 3 commits July 23, 2024 12:10
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Co-authored-by: Predrag Janosevic <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
@pierre-emmanuelJ
Copy link
Member Author

@kobajagi @sauterp description as been adapted accordingly to the performed test on the command.

@pierre-emmanuelJ pierre-emmanuelJ merged commit cc09480 into master Jul 24, 2024
2 checks passed
@pierre-emmanuelJ pierre-emmanuelJ deleted the pej/sc-60922/tooling-support-for-multiple-ssh-keys branch July 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants