Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting #335

Open
bertiqwerty opened this issue Jan 17, 2024 · 4 comments · May be fixed by #336
Open

Update linting #335

bertiqwerty opened this issue Jan 17, 2024 · 4 comments · May be fixed by #336
Assignees

Comments

@bertiqwerty
Copy link
Contributor

Pyright and Ruff are out-dated. We can also try to replace Black by Ruff-Format and have one dependency less.

@bertiqwerty bertiqwerty self-assigned this Jan 17, 2024
@bertiqwerty
Copy link
Contributor Author

from Behrang in #279 (comment)

When I understood this correctly, # type: ignore correctly, it operates on the line level. We could at some point activate reportUnnecessaryTypeIgnoreComment in Pyright's options. See https://github.com/microsoft/pyright/blob/main/docs/comments.md#line-level-diagnostic-suppression

from Johannes in #279 (comment)

Note that I moved the pyright config some time ago into the pyproject.toml, so the new flag for showing the unnecessary ignore statements should also go there, I think:

[tool.pyright]

@bertiqwerty bertiqwerty linked a pull request Jan 17, 2024 that will close this issue
@jduerholt
Copy link
Contributor

Hi Behrang,

I am in favor of using the reportUnnecessaryTypeIgnoreComment keyword and also to replace black by ruff-format!

Best,

Johannes

@TobyBoyne
Copy link
Collaborator

@bertiqwerty Are you still working on this issue? Following #383, there are now many unnecessary # type: ignores in bofire. I would be happy to help to remove some of these, and continue working on the typing system to remove as many of these comments as we can!

@bertiqwerty
Copy link
Contributor Author

Hi Toby, this currently does not have a high priority for me. If you want to give it a try, feel free. You should not continue on MR #336 and restart from scratch, since a lot has changed recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants