Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding log-transformed inputs #349

Open
dlinzner-bcs opened this issue Feb 7, 2024 · 3 comments
Open

Adding log-transformed inputs #349

dlinzner-bcs opened this issue Feb 7, 2024 · 3 comments
Assignees

Comments

@dlinzner-bcs
Copy link
Contributor

We frequently encounter variables that are better modeled in the logarithmic space. It would be a cool feature to have bofire to model this directly.

@niklaswulkow please add/correct ;)

@jduerholt
Copy link
Contributor

Good point, I have it already for a longer time on my bucket list, from the botorch side, this is already prepared:
https://github.com/pytorch/botorch/blob/68fbb68d4a78efd2b803071d883081b2c45a70ae/botorch/models/transforms/input.py#L878
The question is how to set it up in BoFire. I would vote for setting up the domain still in the original non-transformed space and just tell the surrogate which input to transform, as it is currently also done for the input scalers fors continuous inputs. This needs to be made more flexible.

What do you think?

cc: @bertiqwerty: maybe we can discuss this also tmr in our meeting

@jduerholt
Copy link
Contributor

Furthermore, the question would be if the log transformed inputs should then also undergo normalization/standardization and how to set this up in a flexible way.

@jduerholt
Copy link
Contributor

https://ax.dev/docs/models.html#transforms This describes how it is done in Ax, which differs a bit from our current approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants