Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support the new reboot options of dnf-automatic directly #8

Open
agross opened this issue Apr 17, 2024 · 1 comment
Open

Please support the new reboot options of dnf-automatic directly #8

agross opened this issue Apr 17, 2024 · 1 comment

Comments

@agross
Copy link

agross commented Apr 17, 2024

dnf-automatic now supports rebooting internally. Please support these configuration items. I'm referring to reboot and reboot_command in the [commands] section.

https://dnf.readthedocs.io/en/latest/automatic.html#upgrade-type-automatic-label

@exploide
Copy link
Owner

Thanks, I think this is a reasonable addition.

However, I'm not using this role any longer on my own. So maybe I will not implement this in the near future. (Just added some of the other new config variables, which are easier to support.)

On the other hand, I do accept pull requests. So if anyone wants to give it a try...

That being said, I expect this not being a trivial change. LTS distributions like CentOS probably do not have a recent enough dnf for this feature being supported. The role would need to check this, then either use dnf-automatic's build-in reboot mechanism or the existing workaround otherwise. Preferably both using the existing dnf_automatic_reboot variable to not clutter role's interface. However, we can discuss alternative approaches of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants