Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Weasel DVC command error "run" #82

Open
pcschreiber1 opened this issue Mar 3, 2024 · 1 comment · May be fixed by #90
Open

BUG: Weasel DVC command error "run" #82

pcschreiber1 opened this issue Mar 3, 2024 · 1 comment · May be fixed by #90
Labels
bug Something isn't working

Comments

@pcschreiber1
Copy link

Hi, I'm quite new to weasel and ran into this basic problem and haven't been able to figure out a way to solve it.

Expected Behaviour

With running weasel dvc I can automatically create and maintain a dvc.yml from my project.yml.

Current Behaviour

When running weasel dvc I get an error message that "run" is an invalid command choice and no dvc.yml is created.

$ weasel dvc
⚠ No workflow specified for DVC pipeline. Using the first workflow
defined in project.yml: 'all'
ERROR: argument command: invalid choice: 'run' (choose from 'add', 'artifacts', 'cache', 'check-ignore', 'checkout', 'commit', 'completion', 'config', 'daemon', 'dag', 'data',

Steps to reproduce

I ran into this issue with both the templates tagger_parser_ud and textcat_demo as well as the tutorial ner_fashion_brands.

Set-up new project

  1. mkdir new_folder && cd new_folder
  2. python -m venv .venv
  3. source .venv/bin/activate
  4. pip install weasel && pip install dvc
  5. git init && dvc init

Download and set-up template
6. weasel clone pipelines/tagger_parser_ud
7. cd tagger_parser_ud
8. weasel assets

Set-up weasel from project.yml
9. weasel dvc

Environment

  • WSL 2 Ubuntu
  • Python 3.10.12
  • weasel 0.3.4
  • dvc 3.48.1
  • git version 2.34.1

Detailed Description

It seems to me like under the hood a dvc run command is triggered, which causes an issue. It already tried to check the code weasel/cli/dvc.py, but couldn't find a run command there or in utils.

@svlandeg svlandeg added question Further information is requested bug Something isn't working and removed question Further information is requested labels May 14, 2024
@svlandeg
Copy link
Member

Hi! Thanks for the extensive report and way of reproducing. I can reproduce this on my own system as well.

The DVC integration is in a dire need of updating, as this was written before dvc run was deprecated for its 3.0.0 release. Weasel still uses this here.

If I downgrade dvc to version 2.58.2 this error goes away, though I'm running into other issues. We'll have to spend some time looking into this properly.

@svlandeg svlandeg linked a pull request May 14, 2024 that will close this issue
3 tasks
@svlandeg svlandeg linked a pull request May 14, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants